Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DF Chat Enhancements: Players Can't Edit OOC Messages #430

Open
MrVauxs opened this issue Nov 28, 2022 · 2 comments
Open

DF Chat Enhancements: Players Can't Edit OOC Messages #430

MrVauxs opened this issue Nov 28, 2022 · 2 comments
Assignees
Labels
blocked bug Something isn't working

Comments

@MrVauxs
Copy link

MrVauxs commented Nov 28, 2022

Update

I have tested the issue with built-in Foundry /ooc commands, the issue persists, it has nothing to do with other modules forcing or duplicating that sort of speaker mode.

image


Conflicting Module(s)

Describe the conflict
When using the modules button to send an out of character message as a player, the message that gets sent becomes un-editable by DF Chat Enhancements, telling the player they have no permissions to edit it. Despite the fact, that they can using the console.

Expected behavior
The user can edit messages made in either mode.

Screenshots (Optional)
image
image

Additional context (Optional)
MrVauxs/speaking-as#6

@MrVauxs MrVauxs changed the title DF Chat Enhancements: Speaking As DF Chat Enhancements: Can't Edit OOC Nov 28, 2022
@MrVauxs MrVauxs changed the title DF Chat Enhancements: Can't Edit OOC DF Chat Enhancements: Players Can't Edit OOC Nov 28, 2022
@MrVauxs MrVauxs changed the title DF Chat Enhancements: Players Can't Edit OOC DF Chat Enhancements: Players Can't Edit OOC Messages Nov 28, 2022
@chaoticnote
Copy link

chaoticnote commented Dec 15, 2022

UPDATE: Okay, I realize that if a player does not have their token on the Scene, all their messages are considered OOC, and those can't be edited. Once I had sent my player's token down and typed messages, I tried editing them and they work. So yeah, only OOC messages can't be edited.

image
image
My player tried editing a message sent In-Character. He can't change those either. I've disabled and reenabled the setting to allow players to edit messages, and that doesn't seem to work.

@flamewave000 flamewave000 added bug Something isn't working investigation labels Mar 1, 2025
@flamewave000
Copy link
Owner

Unfortunately this appears to be a bizarre permissions issue in Foundry. The error is coming from the server.

The only way around this would be to open a background connection to the current gamemaster (if they're connected) and have their profile delete the message. That's a bit out of scope right now. It would be better if Foundry were to fix this discrepancy in their permission system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants