Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DF Manual Rolls: Bypass Dice So Nice when manual roll entered #455

Open
this-gavagai opened this issue Feb 26, 2023 · 2 comments
Open

DF Manual Rolls: Bypass Dice So Nice when manual roll entered #455

this-gavagai opened this issue Feb 26, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@this-gavagai
Copy link

I really want to thank you for these modules, especially Manual Rolls. I was reluctant to incorporate Foundry into in-person games because I didn't want to lose that feeling of sitting around a table, but Manual Rolls has been the keystone to being able to blend these approaches together.

One question I've had: I control the game from a laptop, and project the map onto a screen behind me. Players have paper character sheets and real dice. I use Foundry + Dice So Nice for GM rolls. In this scenario, is there any way to tell foundry/manual rolls to activate the 3d effects of Dice So Nice only for system rolls and not manual rolls?

I'm just learning Foundry module development, but if this is potentially a desirable feature I'm eager to dig in with a pull request if I can figure it out. Any tips on how to approach this problem would be greatly appreciated.

@this-gavagai this-gavagai added the enhancement New feature or request label Feb 26, 2023
@flamewave000
Copy link
Owner

flamewave000 commented Mar 2, 2023

So there's not at the moment. From my understanding, the way DSN works is that it monitors the chat log and when a chat message with isRoll=true comes in, it grabs the roll object associated with the message and uses it's DiceTerms to figure out what kind of dice were used and how many. If you wanted to prevent it from showing manual rolls, the Manual Rolls module would need to somehow add a Flag to the Roll object and then you would have to patch DSN so that it can detect this flag and ignore the roll.

@this-gavagai
Copy link
Author

Thanks, this is extremely helpful. I'll poke around on the DSN side and see what I can find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants