Added support for exploding dice with manual rolls - likely fix issue #464 #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inxaos
changed the title
flamewave000
force-pushed
the
master
branch
2 times, most recently
from
571cb74 to
7be92e6
Compare
flamewave000
force-pushed
the
master
branch
8 times, most recently
from
ba1b0be to
66a6d12
Compare
flamewave000
force-pushed
the
master
branch
8 times, most recently
from
9e14058 to
8c74029
Compare
|
Since v12 has manual rolling built into core, I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a setting to support Exploding Dice being manually entered (useful for systems such as Savage Worlds / SWADE). Likely resolves #464
Previously, when the die value entered equals the maximum die value, the "exploding" dice are automatically generated afterwards behind the scenes and cannot be entered manually. This setting removes the maximum value validation from the Roll Prompt form, allowing the total of all exploded dice to be entered as a single value, which works properly for further calculations.