Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent access #2 #719

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

miklezzzz
Copy link
Contributor

Some other race conditions to fix have been detected.

Overview

What this PR does / why we need it

Special notes for your reviewer

@miklezzzz miklezzzz added the bug Something isn't working label Feb 18, 2025
@miklezzzz miklezzzz self-assigned this Feb 18, 2025
@miklezzzz miklezzzz force-pushed the fix-concurrent-map-access-2 branch from 62233b3 to 5782d59 Compare February 19, 2025 08:38
@juev
Copy link
Contributor

juev commented Feb 19, 2025

Why not use sync.Map victoriaMetrics blog?

@miklezzzz
Copy link
Contributor Author

miklezzzz commented Feb 19, 2025

to play safe, I suppose.
At first, I felt agitated to use something different like sync.Map, but there are two factors against it there:

  • to stay aligned with the rest of the code;
  • I don't feel the BindingMonitorLinks map experience heavy concurrency load, that would outweigh using a simpler solution.

f
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
@miklezzzz miklezzzz force-pushed the fix-concurrent-map-access-2 branch from 5657f1f to 493af2d Compare February 20, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants