Skip to content

Commit 92b2b4a

Browse files
[1.x] chore: resolve node deprecation warnings in workflows (#4081)
* chore: update frontend workflow Backport of 356f976 * chore: bump default node version and `flarum/action-build` * fix * dummy commit
1 parent 0b55830 commit 92b2b4a

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

.github/workflows/REUSABLE_frontend.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ on:
7474
description: The node version to use for the workflow.
7575
type: number
7676
required: false
77-
default: 16
77+
default: 20
7878

7979
js_package_manager:
8080
description: "Enable TypeScript?"
@@ -105,6 +105,7 @@ env:
105105
ci_script: ${{ inputs.js_package_manager == 'yarn' && 'yarn install --immutable' || 'npm ci' }}
106106
cache_dependency_path: ${{ inputs.cache_dependency_path || format(inputs.js_package_manager == 'yarn' && '{0}/yarn.lock' || '{0}/package-lock.json', inputs.frontend_directory) }}
107107
COMPOSER_AUTH: ${{ secrets.composer_auth }}
108+
DISABLE_V8_COMPILE_CACHE: 1
108109

109110
jobs:
110111
build:
@@ -116,10 +117,10 @@ jobs:
116117
117118
steps:
118119
- name: Check out code
119-
uses: actions/checkout@v3
120+
uses: actions/checkout@v4
120121

121122
- name: Set up Node
122-
uses: actions/setup-node@v3
123+
uses: actions/setup-node@v4
123124
with:
124125
node-version: ${{ inputs.node_version }}
125126
cache: ${{ inputs.js_package_manager }}
@@ -142,7 +143,7 @@ jobs:
142143
working-directory: ${{ inputs.frontend_directory }}
143144

144145
- name: JS Checks & Production Build
145-
uses: flarum/action-build@v3
146+
uses: flarum/action-build@v4
146147
with:
147148
github_token: ${{ secrets.GITHUB_TOKEN }}
148149
build_script: ${{ inputs.build_script }}

js-packages/tsconfig/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"compilerOptions": {
3+
"skipLibCheck": true,
34
"allowUmdGlobalAccess": true,
45
"sourceMap": true,
56
"strict": true,

0 commit comments

Comments
 (0)