Replace nmap netcat with openbsd netcat #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
force-pushed
the
krnowak/drop-nmap
branch
from
2acb518 to
0f24fdb
Compare
|
Unfortunately I think this might break the |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/10261227317 |
Well spotted. Thanks! There is also a kola test that uses ncat ( |
krnowak
force-pushed
the
krnowak/drop-nmap
branch
from
0f24fdb to
fe6f6b2
Compare
krnowak
changed the title
krnowak
force-pushed
the
krnowak/drop-nmap
branch
2 times, most recently
from
ffc989d to
e30f89f
Compare
krnowak
force-pushed
the
krnowak/drop-nmap
branch
from
e30f89f to
73119b1
Compare
|
CI passed. |
chewi
approved these changes
Aug 9, 2024
It's from Gentoo commit adecc0f58f3a727d04e8b397d0e00f0825fde901.
The license of nmap is not acceptable for CNCF and possibly no exception was granted. We will use net-analyzer/openbsd-netcat package instead, which has an acceptable license.
krnowak
force-pushed
the
krnowak/drop-nmap
branch
from
73119b1 to
559464c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces net-analyzer/nmap with net-analyzer/openbsd-netcat. It also installs the
ncatsymlink for compatibility.Fixes flatcar/Flatcar#1460
CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/4414/cldsv/
There are the following PRs in mantle and init that this PR is pulling in:
--
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.