Skip to content

Commit 91aaf4b

Browse files
committed
Small improvements to function documentation in cnmf/temporal
1 parent 2314d2d commit 91aaf4b

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

caiman/source_extraction/cnmf/temporal.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -212,13 +212,14 @@ def update_temporal_components(Y, A, b, Cin, fin, bl=None, c1=None, g=None, sn=N
212212
YrA = YA - AA.T.dot(Cin).T
213213
# creating the patch of components to be computed in parallel
214214
parrllcomp, len_parrllcomp = caiman.source_extraction.cnmf.utilities.update_order_greedy(AA[:nr, :][:, :nr])
215-
logger.info("entering the deconvolution ")
215+
logger.info(f"Entering Deconvolution, {C.shape=} {S.shape=}")
216216
C, S, bl, YrA, c1, sn, g, lam = update_iteration(parrllcomp, len_parrllcomp, nb, C, S, bl, nr,
217217
ITER, YrA, c1, sn, g, Cin, T, nA, dview, debug, AA, kwargs)
218218
ff = np.where(np.sum(C, axis=1) == 0) # remove empty components
219219
if np.size(ff) > 0: # Eliminating empty temporal components
220220
ff = ff[0]
221-
logger.info(f'removing {len(ff)} empty spatial component(s)')
221+
logger.info(f'removing {len(ff)} empty temporal component(s)')
222+
222223
keep = list(range(A.shape[1]))
223224
for i in ff:
224225
keep.remove(i)
@@ -258,9 +259,6 @@ def update_iteration(parrllcomp, len_parrllcomp, nb, C, S, bl, nr,
258259
Cin: np.ndarray
259260
current estimate of temporal components (K x T)
260261
261-
g: np.ndarray
262-
Global time constant (not used)
263-
264262
bl: np.ndarray
265263
baseline for fluorescence trace for each column in A
266264
@@ -314,18 +312,21 @@ def update_iteration(parrllcomp, len_parrllcomp, nb, C, S, bl, nr,
314312
bl: float
315313
same as input
316314
315+
YrA: np.ndarray
316+
matrix of spatial component filtered raw data, after all contributions have been removed.
317+
YrA corresponds to the residual trace for each component and is used for faster plotting (K x T)
318+
317319
c1: float
318320
same as input
319321
320-
g: float
322+
sn: float
321323
same as input
322324
323-
sn: float
325+
g: float
324326
same as input
325327
326-
YrA: np.ndarray
327-
matrix of spatial component filtered raw data, after all contributions have been removed.
328-
YrA corresponds to the residual trace for each component and is used for faster plotting (K x T)
328+
lam: (undocumented)
329+
329330
"""
330331

331332
logger = logging.getLogger("caiman")

0 commit comments

Comments
 (0)