fix: lazy import scipy and matplotlib #2379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaugenst-flex
force-pushed
the
yaugenst-flex/lazy-import-scipy
branch
from
9d8deb9 to
ca5443c
Compare
yaugenst-flex
changed the title
|
hmm actually the mode solver has many more scipy dependencies, not really sure how we should handle that |
|
according to @majinge7846 might be fine as is but we can keep the PR as draft for now in case anything else comes up |
yaugenst-flex
force-pushed
the
yaugenst-flex/lazy-import-scipy
branch
from
ca5443c to
c377111
Compare
|
@yaugenst-flex At least the |
|
Yup this is actually just a dummy PR for MC, we can close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MC ran into an issue with this since scipy and matplotlib are not installed in the minimal tidy3d install and tidy3d still needs to be importable.
@caseyflex @dmarek-flex fyi