-
Notifications
You must be signed in to change notification settings - Fork 58
Non-isothermal charge simulations #2425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
cde4b7a
to
123a335
Compare
123a335
to
a91b7e3
Compare
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changes
Summary
tidy3d/components/tcad/simulation/heat_charge.py
|
60cf9f1
to
f53f91b
Compare
f53f91b
to
11cd469
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile
class SteadyChargeDCAnalysis(Tidy3dBaseModel): | ||
""" | ||
Configures relevant steady-state DC simulation parameters for a charge simulation. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Base class docstring should be more descriptive, mentioning this is for both isothermal and non-isothermal simulations
""" | ||
Configures relevant steady-state DC simulation parameters for a charge simulation. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Docstring should clarify this is specifically for isothermal (constant temperature) simulations
Greptile Summary
Added support for non-isothermal charge simulations by introducing
SteadyChargeDCAnalysis
base class and refactoring the existingIsothermalSteadyChargeDCAnalysis
, enabling temperature variation effects in charge simulations.spice/analysis/dc.py
to support both temperature-varying and fixed-temperature simulations while maintaining backward compatibilitytcad/simulation/heat_charge.py
to ensure structures have both electrical and thermal properties for non-isothermal simulationstest_heat_charge.py
with comprehensive thermal conductivity and medium components__init__.py
to include newSteadyChargeDCAnalysis
class