feat: add validation for grid spacing in AutoGrid #2453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (3e21, True), # dl<1e-6 → fail | ||
| (1e14, False), # dl>1e-7 → pass | ||
| ], | ||
| ) |
There was a problem hiding this comment.
if you just make the simulation size 1e7 smaller wouldn't that avoid the long runtime of the test?
There was a problem hiding this comment.
Yes, it reduces the runtime. Thanks!
| ("freq0", "expect_error"), | ||
| [ | ||
| (3e21, True), # dl<1e-6 → fail | ||
| (1e14, False), # dl>1e-7 → pass |
| @@ -3596,6 +3619,9 @@ def _post_init_validators(self) -> None: | |||
| self._validate_custom_source_time() | |||
| self._validate_mode_object_bends() | |||
| self._warn_mode_object_pml() | |||
| _validate_min_grid_spacing( | |||
| self.grid, threshold=1e-7, msg_prefix=f"'{self.__class__.__name__}'" | |||
| ) | |||
There was a problem hiding this comment.
Let's do 1e-6, even that sounds too large, but to be consistent with the uniform grid validator. Or maybe we should increase the threshold for both? I don't know if I missed anything in the other discussion but wouldn't even 1e-5 be more than reasonable (hard to imagine any simulation that needs to go even below 1e-4). @yaugenst ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
Simulation._post_init_validatorsto compute the minimum cell size (dl) after AutoGrid construction and validate it against threshold [1e-7 µm]. Addresses this issue.Note: The pytest takes a lot of time and memory to run locally, because it builds the full grid before running the dl check.