Singularity correction at metallic edges #2498
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiliangjin2021
added
rc2
weiliangjin2021
force-pushed
the
weiliang/singularity
branch
from
c57b1a0 to
e0ca6b6
Compare
|
Edge correction is now only applied at PEC edges. |
|
Code Coverage SummaryDiff against developResults for commit: e0ca6b6 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
|
Changed Files CoverageResults for commit: e0ca6b6 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
+157
to
+163
| edge_singularity_correction: Literal[False] = pd.Field( | ||
| False, | ||
| title="Apply Singularity Model At Metal Edges", | ||
| description="Apply field correction model at metallic edges where field singularity occurs. " | ||
| "The correction is applied to straight edges aligned with the primal grids, and the wedge angle is either " | ||
| "0 or 90 degree.", | ||
| ) |
There was a problem hiding this comment.
logic: This forces edge_singularity_correction to False for SurfaceImpedance but the rationale isn't documented. Add comment explaining why this must be False
weiliangjin2021
force-pushed
the
weiliang/singularity
branch
from
e0ca6b6 to
b8e9410
Compare
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changes
Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Added field singularity correction capabilities for Perfect Electric Conductor (PEC) edges in electromagnetic simulations, improving accuracy at metallic boundaries.
edge_singularity_correctionparameter intidy3d/components/subpixel_spec.pyfor PECConformal class with default=Truetests/test_components/test_simulation.pyfor edge correction behavior