Setting default mode precision to 'double', except in EME solver #2547
+16
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momchil-flex
force-pushed
the
momchil/default_double
branch
from
58c41c6 to
1f3af6e
Compare
momchil-flex
requested review from
caseyflex,
tomflexcompute,
FilipeFcp and
weiliangjin2021
momchil-flex
force-pushed
the
momchil/default_double
branch
from
f871b75 to
46f48e0
Compare
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changes
Summary
|
tomflexcompute
approved these changes
Jun 6, 2025
caseyflex
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
Great! Yeah we have some other functions like _to_mode_spec that could be made more robust like this in the future. Like in mode/simulation.py; we have MODE_SIM_YEE_SIM_SHARED_ATTRS which should probably be handled like this, just popping the properties that are specific to ModeSimulation. MODE_SIM_MODE_SOLVER_SHARED_ATTRS probably can't be handled like this, since those classes aren't related by simple inheritance
FilipeFcp
approved these changes
Jun 6, 2025
momchil-flex
force-pushed
the
momchil/default_double
branch
from
46f48e0 to
a5c811b
Compare
weiliangjin2021
approved these changes
Jun 7, 2025
momchil-flex
force-pushed
the
momchil/default_double
branch
2 times, most recently
from
a32a007 to
b0bc5d3
Compare
momchil-flex
force-pushed
the
momchil/default_double
branch
from
b0bc5d3 to
a7ce126
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2518 (well, and it goes beyond it to set 'double' by default)
@caseyflex note that I changed the
EMEModeSpec_to_mode_specmethod to be more stable if we e.g. add a new field in theModeSpecthat we just want to directly propagate.