Automatically use periodic boundary on zero-size dimensions #2553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The boundary is silently replaced (per @e-g-melo 's suggestion) for EMESimulation and ModeSimulation. For FDTD Simulation, it gives a warning. Previously, it would error for all simulation types if the boundary was not periodic or bloch. |
|
@momchil-flex let's try to get this in 2.9.0rc1? |
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changes
Summary
|
momchil-flex
approved these changes
Jun 10, 2025
| if size_dim == 0: | ||
| boundaries[dim] = Boundary.periodic() | ||
|
|
||
| return BoundarySpec(x=boundaries[0], y=boundaries[1], z=boundaries[2]) |
There was a problem hiding this comment.
Ah so this validator actually existed but it wasn't taking effect because _boundaries_for_zero_dims = validate_boundaries_for_zero_dims() was also included (and probably executed first?)
There was a problem hiding this comment.
yeah I think that's right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly to address the annoying issue with
ModeSimulation, where if it is 2D, the boundary must be manually set to periodic in the normal direction. It replaces some of this PR for 1D mode solving (#2478), so that we can get it in before all the issues are resolved there.