-
Notifications
You must be signed in to change notification settings - Fork 22
Updated reload_connections set false by default in in_opensearch.rb #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Oleh <o.palanskyi@socprime.com>
Signed-off-by: OlehPalanskyi <Trahterber@gmail.com> Signed-off-by: Oleh <o.palanskyi@socprime.com>
Signed-off-by: OlehPalanskyi <Trahterber@gmail.com> Signed-off-by: Oleh <o.palanskyi@socprime.com>
@@ -215,7 +215,7 @@ def reachable_host?(host) | |||
host: ["#{host[:scheme]}://#{host[:host]}:#{host[:port]}"], | |||
user: host[:user], | |||
password: host[:password], | |||
reload_connections: @reload_connections, | |||
# reload_connections: @reload_connections, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, could you describe why this line is commented out?
Would you mind if you revive this line?
lib/fluent/plugin/in_opensearch.rb
Outdated
@@ -343,14 +343,18 @@ def update_retry_state(error=nil) | |||
@retry = retry_state(@retry_randomize) | |||
end | |||
@retry.step | |||
if error.message.include?('EOFError (EOFError)') | |||
log.error("Restart plugin because hit error #{error.message}") | |||
exit(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exit(1) caused entire termination. This is brutal manner for handling this exception. :(
added Faraday::TimeoutError in retry function
Refactor retry logic
@OlehPalanskyi Thanks for this improvement!
It appears that some diffs are not related to this. |
Hi i getting this error in input when set parameter reload_connections true.
But I found if we set parameter reload_connections false we stop getting this error.
This way I set this parameter reload_connections false by default in code.