chumask: fix issue where it only works with standalone worker #4836
+86
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
Fix #3671 (88a7260)
After #3671, the value of
chumask
passed to ServerEngine was alwaysnil
.The
chumask
value was being used only when standalone. It appears to be unintentional.This fixes it.
0
aschumask
is passed to ServerEngine.--umask
option, that value is passed.chumask
value is applied when usingdaemonize
.daemonize
, the value is not used.Specification change:
(Just undo the specification that #3671 unintentionally changed.)
umask
when usingdaemonize
.nil
for ServerEngine)0
Docs Changes:
Not needed.
(There is not enough information on https://docs.fluentd.org/deployment/command-line-option. It would be good to add more information.)
Release Note:
umask
was not set to0
when using--daemon
(td-agent, fluent-package) since v1.14.6.--umask
command line option: Fixed so that it is applied when Fluentd runs with--daemon
(fluent-package) as well as when Fluentd runs with--no-supervisor
.