Skip to content

Say which file do not have their imports sorted #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bartekpacia opened this issue May 9, 2021 · 1 comment
Open

Say which file do not have their imports sorted #51

bartekpacia opened this issue May 9, 2021 · 1 comment

Comments

@bartekpacia
Copy link
Contributor

bartekpacia commented May 9, 2021

Is your feature request related to a problem? Please describe.
My project is quite big and has many files. That's the output I get after running flutter pub run import_sorter:main --exit-if-changed

┏━━ Sorting 165 dart files
┃  ┣━━  Sorted imports for /lib/repos/repository_social.dart/
┃  ┣━━  Sorted imports for /lib/repos/repository_geolocation.dart/
┃  ┣━━  Sorted imports for /lib/repos/repository_assets.dart/
┃  ┣━━  Sorted imports for /lib/repos/repository_user.dart/
┃  ┣━━  Sorted imports for /lib/repos/repository_info.dart/
┃  ┣━━  Sorted imports for /lib/routes.dart/
┃  ┣━━  Sorted imports for /lib/utils.dart/
┃  ┣━━  Sorted imports for /lib/models/track.dart/
┃  ┣━━  Sorted imports for /lib/models/place_distance_user.dart/
┃  ┣━━  Sorted imports for /lib/models/dayroom.dart/
┃  ┣━━  Sorted imports for /lib/models/dayroom_post.dart/
┃  ┣━━  Sorted imports for /lib/models/story.dart/
┃  ┣━━  Sorted imports for /lib/models/place.dart/
┃  ┣━━  Sorted imports for /lib/models/info.dart/
┃  ┣━━  Sorted imports for /lib/models/user_response.dart/
┃  ┣━━  Sorted imports for /lib/models/air_data.dart/
┃  ┣━━  Sorted imports for /lib/models/comment.dart/
┃  ┣━━  Sorted imports for /lib/models/location.dart/
┃  ┣━━  Sorted imports for /lib/models/section.dart/
┃  ┣━━  Sorted imports for /lib/models/like.dart/
┃  ┣━━  Sorted imports for /lib/models/info_login.dart/
┃  ┣━━  Sorted imports for /lib/models/visit.dart/
┃  ┣━━  Sorted imports for /lib/models/datafile.dart/
┃  ┣━━  Sorted imports for /lib/models/place_distance_social.dart/
┃  ┣━━  Sorted imports for /lib/models/models.dart/
┃  ┣━━  Sorted imports for /lib/blocs/login_info_bloc/login_info_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/login_info_bloc/bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/login_info_bloc/login_info_event.dart/
┃  ┣━━  Sorted imports for /lib/blocs/login_info_bloc/login_info_state.dart/
┃  ┣━━  Sorted imports for /lib/blocs/bool_bloc/bool_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/datafile_bloc/datafile_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/datafile_bloc/datafile_event.dart/
┃  ┣━━  Sorted imports for /lib/blocs/datafile_bloc/bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/datafile_bloc/datafile_state.dart/
┃  ┣━━  Sorted imports for /lib/blocs/comments_bloc/comments_event.dart/
┃  ┣━━  Sorted imports for /lib/blocs/comments_bloc/bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/comments_bloc/comments_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/comments_bloc/comments_state.dart/
┃  ┣━━  Sorted imports for /lib/blocs/datafile_manage_bloc/datafile_manage_state.dart/
┃  ┣━━  Sorted imports for /lib/blocs/datafile_manage_bloc/datafile_manage_event.dart/
┃  ┣━━  Sorted imports for /lib/blocs/datafile_manage_bloc/bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/datafile_manage_bloc/datafile_manage_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/section_bloc/section_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/section_bloc/bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/section_bloc/section_event.dart/
┃  ┣━━  Sorted imports for /lib/blocs/section_bloc/section_state.dart/
┃  ┣━━  Sorted imports for /lib/blocs/location_bloc/location_state.dart/
┃  ┣━━  Sorted imports for /lib/blocs/location_bloc/location_event.dart/
┃  ┣━━  Sorted imports for /lib/blocs/location_bloc/bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/location_bloc/location_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/likes_bloc/likes_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/likes_bloc/bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/likes_bloc/likes_state.dart/
┃  ┣━━  Sorted imports for /lib/blocs/likes_bloc/likes_event.dart/
┃  ┣━━  Sorted imports for /lib/blocs/datafile_infos_bloc/datafile_infos_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/datafile_infos_bloc/datafile_infos_event.dart/
┃  ┣━━  Sorted imports for /lib/blocs/datafile_infos_bloc/bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/datafile_infos_bloc/datafile_infos_state.dart/
┃  ┣━━  Sorted imports for /lib/blocs/map_type_bloc/map_type_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/login_bloc/login_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/login_bloc/login_event.dart/
┃  ┣━━  Sorted imports for /lib/blocs/login_bloc/bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/login_bloc/login_state.dart/
┃  ┣━━  Sorted imports for /lib/blocs/simple_bloc_observer.dart/
┃  ┣━━  Sorted imports for /lib/blocs/distance_bloc/distance_state.dart/
┃  ┣━━  Sorted imports for /lib/blocs/distance_bloc/bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/distance_bloc/distance_event.dart/
┃  ┣━━  Sorted imports for /lib/blocs/distance_bloc/distance_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/info_bloc/info_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/info_bloc/info_event.dart/
┃  ┣━━  Sorted imports for /lib/blocs/info_bloc/info_state.dart/
┃  ┣━━  Sorted imports for /lib/blocs/info_bloc/bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/visits_bloc/visits_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/visits_bloc/visits_state.dart/
┃  ┣━━  Sorted imports for /lib/blocs/visits_bloc/bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/visits_bloc/visits_event.dart/
┃  ┣━━  Sorted imports for /lib/blocs/home_bloc/home_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/auth_bloc/auth_event.dart/
┃  ┣━━  Sorted imports for /lib/blocs/auth_bloc/bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/auth_bloc/auth_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/auth_bloc/auth_state.dart/
┃  ┣━━  Sorted imports for /lib/blocs/sort_mode_bloc/sort_mode_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/air_bloc/air_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/air_bloc/air_state.dart/
┃  ┣━━  Sorted imports for /lib/blocs/air_bloc/bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/air_bloc/air_event.dart/
┃  ┣━━  Sorted imports for /lib/blocs/map_bloc/map_bloc.dart/
┃  ┣━━  Sorted imports for /lib/blocs/map_bloc/map_state.dart/
┃  ┣━━  Sorted imports for /lib/blocs/map_bloc/map_event.dart/
┃  ┣━━  Sorted imports for /lib/blocs/map_bloc/bloc.dart/
┃  ┣━━  Sorted imports for /lib/extensions/query_snapshot.dart/
┃  ┣━━  Sorted imports for /lib/extensions/date_time.dart/
┃  ┣━━  Sorted imports for /lib/extensions/sort_mode.dart/
┃  ┣━━  Sorted imports for /lib/extensions/map.dart/
┃  ┣━━  Sorted imports for /lib/extensions/location_permission.dart/
┃  ┣━━  Sorted imports for /lib/extensions/string.dart/
┃  ┣━━  Sorted imports for /lib/extensions/context.dart/
┃  ┣━━  Sorted imports for /lib/extensions/map_type.dart/
┃  ┣━━  Sorted imports for /lib/extensions/color.dart/
┃  ┣━━  Sorted imports for /lib/screens/home/screen_home.dart/
┃  ┣━━  Sorted imports for /lib/screens/home/pages/page_discover.dart/
┃  ┣━━  Sorted imports for /lib/screens/home/pages/page_info.dart/
┃  ┣━━  Sorted imports for /lib/screens/home/pages/page_my_profile.dart/
┃  ┣━━  Sorted imports for /lib/screens/home/widgets/card_dayroom.dart/
┃  ┣━━  Sorted imports for /lib/screens/home/widgets/card_story.dart/
┃  ┣━━  Sorted imports for /lib/screens/home/widgets/card_air_quality.dart/
┃  ┣━━  Sorted imports for /lib/screens/home/widgets/card_feature.dart/
┃  ┣━━  Sorted imports for /lib/screens/home/widgets/card_info.dart/
┃  ┣━━  Sorted imports for /lib/screens/home/widgets/card_section.dart/
┃  ┣━━  Sorted imports for /lib/screens/screen_story.dart/
┃  ┣━━  Sorted imports for /lib/screens/section/modal_sort_mode.dart/
┃  ┣━━  Sorted imports for /lib/screens/section/screen_section.dart/
┃  ┣━━  Sorted imports for /lib/screens/section/widgets/card_place.dart/
┃  ┣━━  Sorted imports for /lib/screens/intro/screen_intro.dart/
┃  ┣━━  Sorted imports for /lib/screens/intro/image_intro.dart/
┃  ┣━━  Sorted imports for /lib/screens/screen_full_photo_network.dart/
┃  ┣━━  Sorted imports for /lib/screens/screen_about.dart/
┃  ┣━━  Sorted imports for /lib/screens/dayroom/screen_dayroom.dart/
┃  ┣━━  Sorted imports for /lib/screens/air/screen_air.dart/
┃  ┣━━  Sorted imports for /lib/screens/air/widgets/air_indicator.dart/
┃  ┣━━  Sorted imports for /lib/screens/map/card_nearby_place.dart/
┃  ┣━━  Sorted imports for /lib/screens/map/screen_map.dart/
┃  ┣━━  Sorted imports for /lib/screens/map/modal_map_type.dart/
┃  ┣━━  Sorted imports for /lib/screens/screen_error.dart/
┃  ┣━━  Sorted imports for /lib/screens/datafiles/row_auth.dart/
┃  ┣━━  Sorted imports for /lib/screens/datafiles/screen_datafiles.dart/
┃  ┣━━  Sorted imports for /lib/screens/datafiles/card_datafile.dart/
┃  ┣━━  Sorted imports for /lib/screens/place/screen_place.dart/
┃  ┣━━  Sorted imports for /lib/screens/place/comment/bottom_sheet_add_comment.dart/
┃  ┣━━  Sorted imports for /lib/screens/place/comment/new_comment_state.dart/
┃  ┣━━  Sorted imports for /lib/screens/place/comment/new_comment_bloc.dart/
┃  ┣━━  Sorted imports for /lib/screens/place/comment/new_comment_event.dart/
┃  ┣━━  Sorted imports for /lib/screens/place/widgets/dialog_user.dart/
┃  ┣━━  Sorted imports for /lib/screens/place/widgets/row_comment.dart/
┃  ┣━━  Sorted imports for /lib/screens/place/widgets/card_place_overview.dart/
┃  ┣━━  Sorted imports for /lib/screens/place/widgets/hero_place_image_file.dart/
┃  ┣━━  Sorted imports for /lib/screens/place/widgets/row_like.dart/
┃  ┣━━  Sorted imports for /lib/screens/place/widgets/row_visit.dart/
┃  ┣━━  Sorted imports for /lib/screens/place/widgets/hero_place_image_network.dart/
┃  ┣━━  Sorted imports for /lib/screens/screen_full_photo_file.dart/
┃  ┣━━  Sorted imports for /lib/screens/login/screen_login.dart/
┃  ┣━━  Sorted imports for /lib/main.dart/
┃  ┣━━  Sorted imports for /lib/generated_plugin_registrant.dart/
┃  ┣━━  Sorted imports for /lib/config.dart/
┃  ┣━━  Sorted imports for /lib/data/app_data_parser.dart/

┗━━🚨 
pub finished with exit code 1

In the example above, I get error code 1 because imports in lib/app.dart are not sorted. I would like to import_sorter to explicitly tell me why it failed on which files. I'm encountering a very strange bug in my GitHub Actions and more information from import_sorter would greatly help me debug it!

Describe the solution you'd like
I'd like import_sorter to print more information, instead of just exiting with error code 1.

Example:

(...)
┃  ┣━━  Sorted imports for /lib/generated_plugin_registrant.dart/
┃  ┣━━  Sorted imports for /lib/config.dart/
┃  ┣━━  Sorted imports for /lib/data/app_data_parser.dart/

┗━━🚨 
Imports in `/lib/app.dart` are not sorted!

Describe alternatives you've considered
I don't know😅

@bartekpacia bartekpacia changed the title Say which file does not have imports sorted Say which file do not have their imports sorted May 9, 2021
@gleich
Copy link
Member

gleich commented Dec 7, 2021

See #63

@gleich gleich closed this as completed Dec 7, 2021
@gleich gleich reopened this Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants