Add support to use inner traits as inputs/outputs properly #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Gomez Ferrer <andresgomezfrr@users.noreply.github.com>
andresgomezfrr
force-pushed
the
add-support-to-inner-traits
branch
from
9865668 to
a7e078c
Compare
pablocasares
approved these changes
Apr 2, 2024
RRap0so
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fix the usage of inner traits properly, before this fix the usage of
fromLiteralMapof an inner trait we result in a case class with aMap[String, Any]instead of rebuilding the proper case class extending of the trait.Type
Are all requirements met?
Complete description
This fix stores the type of the Product inside the struct using an internal field
__type. This is used inside themapToProductto rebuild the product class if is not possible to extract the product type from the scala type. For example, if you are using a trait inside the case class, it doesn't match with aProduct, because the scala type is the trait so it is not possible to rebuild the proper case class, in this case, you can use this type inside the__typefield to rebuild the proper product class.