Fix upload path of test262 workflow artifact

formalsec · Aug 29, 2024 · 5e4cb71 · 5e4cb71
1 parent c809c3f
commit 5e4cb71
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/test262.yml b/.github/workflows/test262.yml
@@ -8,6 +8,8 @@ jobs:
     env:
       TERM: screen-256color
       OCAML_COMPILER: 4.14
+      RESULTS_FILE: results-test262_${{ github.sha }}.txt
+      SLACK_WEBHOOK_URL: ${{ vars.SLACK_WEBHOOK_URL }}
 
     strategy:
       fail-fast: false
@@ -37,10 +39,10 @@ jobs:
         # The workflow should succeed even if `test` has nonzero return code
         continue-on-error: true
         run: |
-          opam exec -- dune exec -- ecma-sl test --type test262 test/test262/tests/ --webhook-url "$SLACK_WEBHOOK_URL" > results-test262_${{ github.sha }}.txt
+          opam exec -- dune exec -- ecma-sl test --type test262 test/test262/tests --webhook-url "$SLACK_WEBHOOK_URL" > ${{ env.RESULTS_FILE }}
 
       - name: Upload Results
         uses: actions/upload-artifact@v4
         with:
-          name: test262-results
-          path: test262-results.txt
+          name: results-test262
+          path: ${{ env.RESULTS_FILE }}
diff --git a/dune-project b/dune-project
@@ -38,6 +38,7 @@
   lwt
   menhir
   menhirLib
+  tls-lwt
   yojson
   conf-npm
   (smtml (>= 0.0.4))

diff --git a/ecma-sl.opam b/ecma-sl.opam
@@ -24,6 +24,7 @@ depends: [
   "lwt"
   "menhir"
   "menhirLib"
+  "tls-lwt"
   "yojson"
   "conf-npm"
   "smtml" {>= "0.0.4"}
-Original file line number
+Diff line change
@@ Expand Up / @@ -38,6 +38,7 @@ @@
       lwt
       menhir
       menhirLib
+      tls-lwt
       yojson
       conf-npm
       (smtml (>= 0.0.4))
@@ Expand Down @@