Fix upload path of test262 workflow artifact

formalsec · Aug 29, 2024 · 907fc67 · 907fc67
1 parent c809c3f
commit 907fc67
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/test262.yml b/.github/workflows/test262.yml
@@ -8,6 +8,7 @@ jobs:
     env:
       TERM: screen-256color
       OCAML_COMPILER: 4.14
+      RESULTS_FILE: results-test262_${{ github.sha }}.txt
 
     strategy:
       fail-fast: false
@@ -37,10 +38,11 @@ jobs:
         # The workflow should succeed even if `test` has nonzero return code
         continue-on-error: true
         run: |
-          opam exec -- dune exec -- ecma-sl test --type test262 test/test262/tests/ --webhook-url "$SLACK_WEBHOOK_URL" > results-test262_${{ github.sha }}.txt
+          echo "$SLACK_WEBHOOK_URL"
+          opam exec -- dune exec -- ecma-sl test --type test262 test/test262/tests/built-ins/Boolean --webhook-url "$SLACK_WEBHOOK_URL" > ${{ env.RESULTS_FILE }}
 
       - name: Upload Results
         uses: actions/upload-artifact@v4
         with:
-          name: test262-results
-          path: test262-results.txt
+          name: results-test262
+          path: ${{ env.RESULTS_FILE }}
diff --git a/bin/commands/cmd_test.ml b/bin/commands/cmd_test.ml
@@ -435,6 +435,7 @@ let test_summary (output : Fpath.t option) (total_time : float)
 
 (* Best effort to send a notification, not critical so just fail silently *)
 let notify_done (tree : TestTree.t) (url : string) : unit =
+  Fmt.eprintf "Debug(url): %s@." url;
   let url = Webhook.url_of_string url in
   let head = Git.get_head () in
   let title = Fmt.str "Test results (commit hash=%s) :octopus:" head in