From 907fc6786b8be3fd76de1c43b1edbcae1ad4986d Mon Sep 17 00:00:00 2001 From: Filipe Marques Date: Thu, 29 Aug 2024 09:32:56 +0200 Subject: [PATCH] Fix upload path of test262 workflow artifact --- .github/workflows/test262.yml | 8 +++++--- bin/commands/cmd_test.ml | 1 + 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test262.yml b/.github/workflows/test262.yml index 52d27a598c..1b1a5bfd7b 100644 --- a/.github/workflows/test262.yml +++ b/.github/workflows/test262.yml @@ -8,6 +8,7 @@ jobs: env: TERM: screen-256color OCAML_COMPILER: 4.14 + RESULTS_FILE: results-test262_${{ github.sha }}.txt strategy: fail-fast: false @@ -37,10 +38,11 @@ jobs: # The workflow should succeed even if `test` has nonzero return code continue-on-error: true run: | - opam exec -- dune exec -- ecma-sl test --type test262 test/test262/tests/ --webhook-url "$SLACK_WEBHOOK_URL" > results-test262_${{ github.sha }}.txt + echo "$SLACK_WEBHOOK_URL" + opam exec -- dune exec -- ecma-sl test --type test262 test/test262/tests/built-ins/Boolean --webhook-url "$SLACK_WEBHOOK_URL" > ${{ env.RESULTS_FILE }} - name: Upload Results uses: actions/upload-artifact@v4 with: - name: test262-results - path: test262-results.txt + name: results-test262 + path: ${{ env.RESULTS_FILE }} diff --git a/bin/commands/cmd_test.ml b/bin/commands/cmd_test.ml index 5a2156c66f..e9354e2f7f 100644 --- a/bin/commands/cmd_test.ml +++ b/bin/commands/cmd_test.ml @@ -435,6 +435,7 @@ let test_summary (output : Fpath.t option) (total_time : float) (* Best effort to send a notification, not critical so just fail silently *) let notify_done (tree : TestTree.t) (url : string) : unit = + Fmt.eprintf "Debug(url): %s@." url; let url = Webhook.url_of_string url in let head = Git.get_head () in let title = Fmt.str "Test results (commit hash=%s) :octopus:" head in