Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address #898
The problem was in the interface
gpx
(meant for internal use only) which had two procedures forx, p are real
andx is real, p is an integer
,p being > 0
in all casesEverything was fine with the second procedure but in the first one it is required that (Fast and accurate evaluation of a
generalized incomplete gamma function)
when x < 0, p be an integer
which wasn't actually programmed in the procedure itself but was being taken care of as and when requiring to callgpx
in such a case. like so https://github.com/fortran-lang/stdlib/blob/master/src/stdlib_specialfunctions_gamma.fypp#L1078-L1099And hence this was not found earlier as the chunk of code was in the case when
x<0 and p<p_lim(x)
(check Algorithm 3) which is now unreachable, hence removed