From 27d1817c30673cb7584090c9a519215c62ea7e1d Mon Sep 17 00:00:00 2001 From: Stephan Cilliers <5469870+stephancill@users.noreply.github.com> Date: Tue, 2 Apr 2024 13:48:40 +0200 Subject: [PATCH 1/2] feat: relative url support for images --- .changeset/light-fireants-rest.md | 5 +++++ packages/frames.js/src/middleware/renderResponse.ts | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 .changeset/light-fireants-rest.md diff --git a/.changeset/light-fireants-rest.md b/.changeset/light-fireants-rest.md new file mode 100644 index 000000000..10731d606 --- /dev/null +++ b/.changeset/light-fireants-rest.md @@ -0,0 +1,5 @@ +--- +"frames.js": patch +--- + +feat: relative url support for images diff --git a/packages/frames.js/src/middleware/renderResponse.ts b/packages/frames.js/src/middleware/renderResponse.ts index 9372c5e20..6659f404b 100644 --- a/packages/frames.js/src/middleware/renderResponse.ts +++ b/packages/frames.js/src/middleware/renderResponse.ts @@ -109,7 +109,11 @@ export function renderResponse(): FramesMiddleware { // and disabling it, has no effect on final bundle size of app image: typeof result.image === "string" - ? result.image + ? generateTargetURL({ + target: result.image, + currentURL: context.url, + basePath: context.basePath, + }) : await renderImage(result.image, result.imageOptions).catch( (e) => { console.error(e); From f7b00b0358b6e58dded5ed5950c5722fd6154dae Mon Sep 17 00:00:00 2001 From: Stephan Cilliers <5469870+stephancill@users.noreply.github.com> Date: Tue, 2 Apr 2024 15:15:05 +0200 Subject: [PATCH 2/2] fix: tests --- packages/frames.js/src/middleware/openframes.test.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/frames.js/src/middleware/openframes.test.ts b/packages/frames.js/src/middleware/openframes.test.ts index 0bd51a603..64610b484 100644 --- a/packages/frames.js/src/middleware/openframes.test.ts +++ b/packages/frames.js/src/middleware/openframes.test.ts @@ -116,6 +116,8 @@ describe("openframes middleware", () => { method: "POST", body: JSON.stringify(signedPayload), }), + url: new URL("https://example.com").toString(), + basePath: "/", } as any; const mw1 = openframes({