-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add onMissingSigner
callback
#538
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
8cc49fd
to
0fa5f34
Compare
6d9409b
to
29107bd
Compare
@michalkvasnicak do we want to add it into stable |
f048495
to
b4aa15d
Compare
29107bd
to
462788a
Compare
michalkvasnicak
approved these changes
Jan 28, 2025
stephancill
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Previously in order to determine when the signer is missing but required by the button action, it requires the devs to add callback
onMissingIdentity
touseFarcasterMultiIdentity
to determine such event, which is not very straight forward.(when signer is missing the hook calls into
frameStae.signerState.onSignerlessFramePress
, which in turns triggersonMissingIdentity
callback on theuseFarcasterMultiIdentity
)The PR adds a dedicated
onMissingSigner
callback foruseFrame_unstable
. The callback will be called when the button action requires a signer but signer is not found.@michalkvasnicak by looking at the code, it feels to me that adding
onTransactionButtonError
/onPostButtonError
could be confusing, I am worrying the naming could give developers a false impression that all errors happened within transaction/post button action will be caught by the callbacks. (unless we change all errors within button action to also trigger the callbacks?). hence in this PR I renamed the callback name to be more specific.Merge Checklist