Wrist Mechanism

[Arbitr-ary-ily]

No description provided.

[Jolteous]

Good job, looks like it will work. We won't impose a lot of our coding standards on you, but I suggest you look at other repositories to get a feel for commenting, formatting and structure.

[flashrun24]

I'm kind of confused how you plan on controlling the wrist, you have a variable that does nothing, several things that assign values to the variable that does nothing, and you are also using button bindings while also passing the joystick to the command. Please figure out what you want to do, I have commented on where the issues I see are, please make the necessary changes.

[Jolteous]

I must've been high when I originally reviewed this, this code will not work due to structural conflicts, as Sepandar has said, you also need to clear out all the stuff that doesn't matter like Choreo and phoenix6replay. Please start to follow conventional coding practices that our team has, and collaborate with each other to follow through. The slides are always up for you to review if you don't remember our standards.

[Jolteous]

Some of these methods look like 2024, not 2025, did you copy over from other repos? That isn't going to work unfortunately.

[Jolteous]

The naming conventions are wrong, also the positioning is not correct, you have lots of extraneous items such as STOW_POSITION, HOME_POSITION, which are set to the same thing, and you aren't using your target position either.

[flashrun24]

You still need to fix some naming conventions and make sure that the controller that is being passed to the wrist subsystem is the operator controller.

[Jolteous]

@Arbitr-ary-ily @RoyalStrawberries Merge this yourself, by the end of tomorrow

[Jolteous]

code is mediocre and weird logic but we'll let it slide

[flashrun24]

There are definitely things that still need to be worked on but it looks like its good to merge. Please resolve the conflict and merge.

[Arbitr-ary-ily]

Alright, I'll do it now @Jolteous @flashrun24 -- I appreciate the feedback and in the future, I'll make sure to adhere to the code quality guidelines/practices of this team.