Add some more cmake options for downloads etc #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messmerd
reviewed
Feb 14, 2025
Comment on lines
+105
to
+106
| - name: Configure project (not next) | ||
| if: github.ref != 'refs/heads/next' |
There was a problem hiding this comment.
Suggested change
| - name: Configure project (not next) | |
| if: github.ref != 'refs/heads/next' | |
| - name: Configure project (main) | |
| if: github.ref == 'refs/heads/main' |
Would this be better?
There was a problem hiding this comment.
The reason I did it this way is if in the future we add a feature branch and want ci then it will work. But I thought about your way too. I’m not sure
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
|
Should |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two cmake options