Merge pull request #3 from freelancerwebro/feature/update_readme

Implement band validation

Author: freelancerwebro

config/services.yaml

@@ -28,4 +28,7 @@ services:
 
     App\Validator\ExcelFileValidator:
         arguments:
-            $validator: '@validator'
+            $validator: '@validator'
+
+    App\Serializer\BandNormalizer:
+        tags: [ 'serializer.normalizer' ]

src/Controller/BandController.php

@@ -100,7 +100,7 @@ public function create(
             'json'
         );
 
-        $errors = $validator->validate($band);
+        $errors = $validator->validate($band, null, ['create']);
         if (count($errors) > 0) {
             return $this->json($errors, 422);
         }
@@ -135,15 +135,19 @@ public function create(
      */
     #[Route('/band/{id}', name: 'app_band_update', methods: ['PUT'])]
     public function update(
+        int $id,
         Request $request,
         SerializerInterface $serializer,
         ValidatorInterface $validator,
-        Band $band,
     ): JsonResponse {
+        $band = $this->bandRepository->find($id);
+        if (!$band) {
+            return $this->json(['error' => 'Band not found'], 404);
+        }
+
         $band = $serializer->deserialize(
             $request->getContent(),
             Band::class,
-
             'json',
             [
                 AbstractNormalizer::OBJECT_TO_POPULATE => $band,
@@ -155,7 +159,7 @@ public function update(
             return $this->json($errors, 422);
         }
 
-        $this->bandRepository->save($band);
+        $this->bandRepository->flush();
 
         return $this->json($band);
     }

src/Entity/Band.php

@@ -5,6 +5,7 @@
 use App\Repository\BandRepository;
 use Doctrine\DBAL\Types\Types;
 use Doctrine\ORM\Mapping as ORM;
+use Symfony\Component\Validator\Constraints as Assert;
 
 #[ORM\Entity(repositoryClass: BandRepository::class)]
 class Band
@@ -15,24 +16,34 @@ class Band
     private ?int $id = null;
 
     #[ORM\Column(length: 30)]
+    #[Assert\NotBlank(message: 'Name is required.', groups: ['create'])]
     private ?string $name = null;
 
     #[ORM\Column(length: 30)]
+    #[Assert\NotBlank(message: 'Origin is required.', groups: ['create'])]
     private ?string $origin = null;
 
     #[ORM\Column(length: 30)]
+    #[Assert\NotBlank(message: 'City is required.', groups: ['create'])]
     private ?string $city = null;
 
     #[ORM\Column(type: Types::SMALLINT)]
+    #[Assert\NotBlank(message: 'Start year is required.', groups: ['create'])]
+    #[Assert\Type(type: 'integer', message: 'Start year must be an integer.')]
+    #[Assert\Range(notInRangeMessage: 'Start year must be between 1900 and 2100.', min: 1900, max: 2100)]
     private ?int $startYear = null;
 
     #[ORM\Column(type: Types::SMALLINT, nullable: true)]
+    #[Assert\Type(type: 'integer', message: 'Separation year must be an integer.')]
+    #[Assert\Range(notInRangeMessage: 'Separation year must be between 1900 and 2100.', min: 1900, max: 2100)]
     private ?int $separationYear = null;
 
     #[ORM\Column(length: 255, nullable: true)]
     private ?string $founders = null;
 
     #[ORM\Column(type: Types::SMALLINT, nullable: true)]
+    #[Assert\Type(type: 'integer', message: 'Members must be an integer.')]
+    #[Assert\Range(notInRangeMessage: 'Members must be between 1 and 50.', min: 1, max: 50)]
     private ?int $members = null;
 
     #[ORM\Column(length: 30, nullable: true)]

src/Repository/BandRepository.php

@@ -22,6 +22,11 @@ public function save(Band $band)
         $this->getEntityManager()->flush();
     }
 
+    public function flush()
+    {
+        $this->getEntityManager()->flush();
+    }
+
     public function delete(Band $band)
     {
         $this->getEntityManager()->remove($band);

src/Serializer/BandNormalizer.php

@@ -0,0 +1,66 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Serializer;
+
+use App\Entity\Band;
+use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;
+use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
+
+class BandNormalizer implements DenormalizerInterface
+{
+    public function denormalize(mixed $data, string $type, ?string $format = null, array $context = []): mixed
+    {
+        if (Band::class !== $type) {
+            return null;
+        }
+        $existingBand = $context[AbstractNormalizer::OBJECT_TO_POPULATE] ?? null;
+
+        if ($existingBand instanceof Band) {
+            $band = $existingBand;
+        } else {
+            $band = new Band();
+        }
+
+        if (isset($data['name'])) {
+            $band->setName($data['name']);
+        }
+        if (isset($data['origin'])) {
+            $band->setOrigin($data['origin']);
+        }
+        if (isset($data['city'])) {
+            $band->setCity($data['city']);
+        }
+        if (isset($data['startYear'])) {
+            $band->setStartYear((int) $data['startYear']);
+        }
+        if (isset($data['separationYear'])) {
+            $band->setSeparationYear((int) $data['separationYear']);
+        }
+        if (isset($data['founders'])) {
+            $band->setFounders($data['founders']);
+        }
+        if (isset($data['members'])) {
+            $band->setMembers((int) $data['members']);
+        }
+        if (isset($data['musicalCurrent'])) {
+            $band->setMusicalCurrent($data['musicalCurrent']);
+        }
+        if (isset($data['presentation'])) {
+            $band->setPresentation($data['presentation']);
+        }
+
+        return $band;
+    }
+
+    public function supportsDenormalization(mixed $data, string $type, ?string $format = null, array $context = []): bool
+    {
+        return Band::class === $type;
+    }
+
+    public function getSupportedTypes(?string $format): array
+    {
+        return [Band::class => true];
+    }
+}

tests/Functional/Controller/BandControllerTest.php

@@ -154,8 +154,8 @@ public function test_update_nonexistent_band()
         );
 
         $response = $this->client->getResponse();
-        $this->assertEquals(Response::HTTP_BAD_REQUEST, $response->getStatusCode());
-        $this->assertStringContainsString('object not found', $response->getContent());
+        $this->assertEquals(Response::HTTP_NOT_FOUND, $response->getStatusCode());
+        $this->assertStringContainsString('Band not found', $response->getContent());
     }
 
     public function test_get_nonexistent_url()