fix(app):Added mow to pacer_to_cl_ids and implemented a logger to detect similar issues

Fixes:

Author: albertisfu

.pre-commit-config.yaml

@@ -21,18 +21,18 @@ repos:
        args: [--markdown-linebreak-ext=md]
 
   - repo: https://github.com/ikamensh/flynt/
-    rev: '0.76'
+    rev: '1.0.1'
     hooks:
      - id: flynt
        args: [--line-length=79, --transform-concats]
 
   - repo: https://github.com/psf/black
-    rev: 21.12b0
+    rev: 25.1.0
     hooks:
      - id: black
 
   - repo: https://github.com/PyCQA/isort
-    rev: 5.10.1
+    rev: 6.0.0
     hooks:
      - id: isort
        name: isort (python)

cl/events/pacer-2.json

@@ -161,9 +161,9 @@
                         }
                     ],
                     "commonHeaders": {
-                        "returnPath": "buttons@whlawpartners.com",
+                        "returnPath": "ecfMOW.notification@mow.uscourts.gov",
                         "from": [
-                            "Buttons McGee <buttons@whlawpartners.com>"
+                            "<ecfMOW.notification@mow.uscourts.gov>"
                         ],
                         "date": "Mon, 28 Jun 2021 13:51:08 -0500",
                         "to": [

cl/recap_email/app/app.py

@@ -1,5 +1,6 @@
 import json
 import os
+import re
 import sys
 
 import requests
@@ -139,6 +140,22 @@ def get_cl_court_id(email):
     return map_pacer_to_cl_id(sub_domain)
 
 
+def log_invalid_court_error(response):
+    """Checks if the response indicates an invalid court pk then send a report
+    to Sentry.
+    """
+    if response.status_code != 400:
+        return
+
+    for msg in response.json().get("court", []):
+        if "Invalid pk" in msg:
+            match = re.search(r'Invalid pk "([^"]+)"', msg)
+            if match:
+                error_message = f"Invalid court pk: {match.group(1)}"
+                sentry_sdk.capture_message(error_message, level="error")
+                break
+
+
 @retry(
     (RequestsConnectionError, HTTPError, Timeout),
     tries=5,
@@ -161,7 +178,7 @@ def send_to_court_listener(email, receipt):
         timeout=5,
         headers={
             "Content-Type": "application/json",
-            "Authorization": "Token " + os.getenv("AUTH_TOKEN"),
+            "Authorization": f"Token {os.getenv('AUTH_TOKEN')}",
         },
     )
 
@@ -170,6 +187,8 @@ def send_to_court_listener(email, receipt):
         # Gateway Timeout status codes.
         court_listener_response.raise_for_status()
 
+    log_invalid_court_error(court_listener_response)
+
     print(
         f"Got {court_listener_response.status_code=} and content "
         f"{court_listener_response.json()=}"

cl/recap_email/app/pacer.py

@@ -5,6 +5,7 @@
     "neb": "nebraskab",  # Nebraska Bankruptcy
     "nysb-mega": "nysb",  # Remove the mega thing
     "txs": "txsd",  # Southern District Of Texas
+    "mow": "mowd",  # Western District of Missouri
 }
 
 # Reverse dict of pacer_to_cl_ids

cl/tests/unit/test_recap_email_handler.py

@@ -7,6 +7,8 @@
 import requests  # noqa: F401
 import requests_mock  # noqa: F401
 from recap_email.app import app  # pylint: disable=import-error
+from recap_email.app.pacer import pacer_to_cl_ids
+from tests.unit.utils import MockResponse
 
 
 @pytest.fixture()
@@ -112,6 +114,17 @@ def test_multiple_domains_success():
         assert app.check_valid_domain(email) == 1
 
 
+def test_get_cl_court_id_using_mapping():
+    for pacer_id, expected_cl in pacer_to_cl_ids.items():
+        email = {
+            "common_headers": {"from": [f"ecfnotices@{pacer_id}.uscourts.gov"]}
+        }
+        result = app.get_cl_court_id(email)
+        assert (
+            result == expected_cl
+        ), f"For PACER id '{pacer_id}', expected CL id '{expected_cl}' but got '{result}'."
+
+
 @pytest.fixture()
 def valid_domain_failure_ses_event():
     with open("./events/ses-valid-domain-failure.json") as file:
@@ -208,3 +221,61 @@ def test_success(
         assert response["statusCode"] == 200
         assert "mail" in data
         assert "receipt" in data
+
+
+@mock.patch.dict(
+    os.environ,
+    {
+        "RECAP_EMAIL_ENDPOINT": "http://host.docker.internal:8000/api/rest/v3/recap-email/",
+        "AUTH_TOKEN": "************************",
+    },
+)
+def test_request_court_field_actual_value(pacer_event_two, requests_mock):
+    """Confirm that the court_id in the request uses the right value
+    from map_pacer_to_cl_id"""
+    requests_mock.post(
+        "http://host.docker.internal:8000/api/rest/v3/recap-email/",
+        json={"mail": {}, "receipt": {}},
+    )
+
+    response = app.handler(pacer_event_two, "")
+    assert response["statusCode"] == 200
+
+    # Retrieve the request that made by send_to_court_listener
+    request = requests_mock.request_history[0]
+    body = json.loads(request.body)
+    assert (
+        body.get("court") == "mowd"
+    ), f"Expected 'mowd', but got '{body.get('court')}'"
+
+
+@mock.patch.dict(
+    os.environ,
+    {
+        "RECAP_EMAIL_ENDPOINT": "http://host.docker.internal:8000/api/rest/v3/recap-email/",
+        "AUTH_TOKEN": "************************",
+    },
+)
+def test_report_request_for_invalid_court(pacer_event_one, requests_mock):
+    """Confirm that if an invalid court_id is sent to CL, an error event is
+    sent to Sentry."""
+
+    mock_response = MockResponse(
+        400, {"court": ['Invalid pk "whla" - object does not exist.']}
+    )
+    with (
+        mock.patch(
+            "recap_email.app.app.requests.post", return_value=mock_response
+        ),
+        mock.patch(
+            "recap_email.app.app.sentry_sdk.capture_message"
+        ) as mock_sentry_capture,
+    ):
+        requests_mock.post(
+            "http://host.docker.internal:8000/api/rest/v3/recap-email/",
+            json={"mail": {}, "receipt": {}},
+        )
+        app.handler(pacer_event_one, "")
+    # The expected error message should be sent to Sentry.
+    expected_error = "Invalid court pk: whla"
+    mock_sentry_capture.assert_called_with(expected_error, level="error")

cl/tests/unit/utils.py

@@ -0,0 +1,9 @@
+
+
+class MockResponse:
+    def __init__(self, status_code, json_data):
+        self.status_code = status_code
+        self._json_data = json_data
+
+    def json(self):
+        return self._json_data

requirements.txt

@@ -1 +1 @@
-pre-commit==2.17.0
+pre-commit==4.1.0