Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16 Added mow to pacer_to_cl_ids and implemented a logger to detect similar issues #17

Merged
merged 4 commits into from
Mar 13, 2025

Conversation

albertisfu
Copy link
Contributor

@albertisfu albertisfu commented Mar 13, 2025

This PR resolves #16 by adding mow->mowd to the pacer_to_cl_ids mapping.

Additionally, a method was added to send similar issues to Sentry. If an email is received indicating that CL returns an invalid court PK error, the issue is reported so we can take action and fix the problem by adding the required court mapping.

New related tests have been added for these changes.

The CI actions have also been updated, as they were no longer compatible with the GitHub environment.
Additionally, related lint complaints were fixed to ensure they pass.

@albertisfu albertisfu force-pushed the 16-add-mow-to-pacer-to-cl-ids-and-log-similar-issues branch from ceed601 to 6195a5a Compare March 13, 2025 02:15
@albertisfu albertisfu force-pushed the 16-add-mow-to-pacer-to-cl-ids-and-log-similar-issues branch from 6195a5a to 357862e Compare March 13, 2025 02:27
@albertisfu albertisfu marked this pull request as ready for review March 13, 2025 18:14
@albertisfu albertisfu requested a review from mlissner March 13, 2025 18:14
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@mlissner mlissner merged commit 18cf6fb into main Mar 13, 2025
9 checks passed
@mlissner mlissner deleted the 16-add-mow-to-pacer-to-cl-ids-and-log-similar-issues branch March 13, 2025 19:10
@mlissner
Copy link
Member

It doesn't look like we have automated deployment for this, do we? I totally forget, but I'm not seeing it in the Github Actions.

@albertisfu
Copy link
Contributor Author

no, we deployed it manually. I'll take care of this unless I run into permission issues, in which case I'll ask for help

@albertisfu
Copy link
Contributor Author

Ok, this is already deployed!

I'm not sure if updating the runtime in the template to 3.11 caused the environment variables to be cleared during the deployment process. However, after the deployment, I found that they were not set. So, I immediately set them again via the console. That caused 4 recap-email requests to return an invalid token from CL. To fix it I created the EPQs using the admin panel and processed them manually, so this is resolved.

Next time we deploy this, I'll review the environment variables being set. They probably need to be passed during deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

mowd emails are not being delivered to CL due to an incorrect court ID extracted from the email
2 participants