-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test and fix for issue #167 #168
Conversation
I never know how to debug any of these GH actions, unfortunately |
Fair enough. @cbrew, what do you think? |
I don’t think Lexis would thank me for spending the time. I was game if it
was going to take only a little time. So if someone can take it, great.
I’m interested in finding out how far new tech can take us in delimiting
the borders of the citing language, either with or without assumptions
about which passage the citation is pointing to. The chance of having both
ends of the graph edge visible in pile of law goes up fast as its coverage
increases. Having your tool as an experimental tool is a delight.
…On Thu, Feb 22, 2024 at 20:07 Mike Lissner ***@***.***> wrote:
Looks like we've got issues with our build unrelated to this PR. @cbrew
<https://github.com/cbrew>, do I guess correctly that you'd rather not go
down this rabbit hole? If so, I can ask somebody on our staff to do so, or
it's possible @mattdahl <https://github.com/mattdahl> might be game.
—
Reply to this email directly, view it on GitHub
<#168 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFIW2R2ALRGLWH6QCKWYHTYU7TTZAVCNFSM6AAAAABDPUJBA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRQGU4TONZXHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No worries! One of our devs fixed the testing problem (hopefully). Now the only issue is that your code isn't passing the linting rule for a very minor reason. Mind fixing that and then we'll be good to go? |
still getting a mystery error about "resource not accessible ny integration' |
@ERosendo can you take another look at getting this one over the hump, please? Thanks Chris! |
@mlissner I've updated this PR and I've made some minor code changes to avoid unnecessary updates to the poetry.lock file. All tests are passing and the linting check is successful. I believe the current issue with the Benchmark Pull Request check is related to token permissions. Workflows triggered by pull requests from forked repositories use a |
Excellent, thank you, merging! |
Hash function did not handle datetime and failed.