Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test and fix for issue #167 #168

Merged
merged 2 commits into from
Feb 27, 2024
Merged

test and fix for issue #167 #168

merged 2 commits into from
Feb 27, 2024

Conversation

cbrew
Copy link
Contributor

@cbrew cbrew commented Feb 19, 2024

Hash function did not handle datetime and failed.

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2024

CLA assistant check
All committers have signed the CLA.

@mlissner
Copy link
Member

Looks like we've got issues with our build unrelated to this PR. @cbrew, do I guess correctly that you'd rather not go down this rabbit hole? If so, I can ask somebody on our staff to do so, or it's possible @mattdahl might be game.

@mattdahl
Copy link
Contributor

I never know how to debug any of these GH actions, unfortunately

@mlissner
Copy link
Member

Fair enough. @cbrew, what do you think?

@cbrew
Copy link
Contributor Author

cbrew commented Feb 23, 2024 via email

@mlissner
Copy link
Member

No worries! One of our devs fixed the testing problem (hopefully).

Now the only issue is that your code isn't passing the linting rule for a very minor reason. Mind fixing that and then we'll be good to go?

@cbrew
Copy link
Contributor Author

cbrew commented Feb 24, 2024

still getting a mystery error about "resource not accessible ny integration'

@mlissner
Copy link
Member

@ERosendo can you take another look at getting this one over the hump, please?

Thanks Chris!

@ERosendo
Copy link
Contributor

@mlissner I've updated this PR and I've made some minor code changes to avoid unnecessary updates to the poetry.lock file. All tests are passing and the linting check is successful.

I believe the current issue with the Benchmark Pull Request check is related to token permissions. Workflows triggered by pull requests from forked repositories use a read-only token and all other secrets are not available to the workflow run. This means any attempts to write, such as creating comments on the pull request using GITHUB_TOKEN or other secrets, will fail.

@mlissner mlissner merged commit ac332c4 into freelawproject:main Feb 27, 2024
7 of 8 checks passed
@mlissner
Copy link
Member

Excellent, thank you, merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants