Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing python 3.12 syntax warning re invalid escape sequence #23

Merged

Conversation

legaltextai
Copy link
Contributor

No description provided.

@mlissner mlissner merged commit 2e02cef into freelawproject:main Aug 28, 2024
2 checks passed
@mlissner
Copy link
Member

Looks good! A couple process things for future PRs:

  1. Your commit messages should match our style, which is explained in our dev guide (see number three here: https://github.com/freelawproject/courtlistener/wiki/Getting-Started-Developing-CourtListener/0c803bbbb92eac2fac2f5d79dbff4689f001acc2#guidelines-for-contributions)

  2. When you're ready for a review, please request a review from me via the "Reviewers" thing in the sidebar. That way, I'll know it's ready for me.

  3. Github has a trick for automatically closing issues that we should use here: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword. If you do this, the issue gets automatically closed when your code is merged.

  4. You should put this PR on your backlog in the "In Review" section, so you can monitor it.

And I think that's it for process! Thanks for this. It's a relief to finally have these errors going away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants