feat(judge-pics): remove support for python 3.8 and below

.github/workflows/check_changelog.yml

@@ -0,0 +1,15 @@
+name: Check release notes
+
+on:
+  pull_request:
+    branches:
+      - 'main'
+
+jobs:
+  Check-Changelog:
+    name: Check Changelog Action
+    runs-on: ubuntu-latest
+    steps:
+      - uses: tarides/changelog-check-action@v2
+        with:
+          changelog: CHANGES.md

.github/workflows/lint.yml

@@ -3,12 +3,9 @@ name: Lint
 on: [push, pull_request]
 
 jobs:
-  black:
+  pre-commit:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-python@v5
-        with:
-          python-version: "3.12"
-      - name: Black Code Formatter
-        uses: psf/black@stable
+      - uses: pre-commit/action@v3.0.0

.github/workflows/tests.yml

@@ -9,7 +9,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
 
     steps:
     - uses: actions/checkout@v4

.github/workflows/upload.yml

@@ -25,6 +25,8 @@ jobs:
           python3 upload.py \
           -a ${{ secrets.AWS_ACCESS_KEY }} \
           -s ${{ secrets.AWS_SECRET_KEY }}
+      - name: Install packaging
+        run: python -m pip install -U packaging
       - name: Publish package
         uses: casperdcl/deploy-pypi@v2
         with:

.pre-commit-config.yaml

@@ -0,0 +1,21 @@
+# See https://pre-commit.com for more information
+# See https://pre-commit.com/hooks.html for more hooks
+repos:
+-   repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v4.6.0
+    hooks:
+    -   id: trailing-whitespace
+    -   id: end-of-file-fixer
+    -   id: check-yaml
+    -   id: check-added-large-files
+
+-   repo: https://github.com/psf/black
+    rev: 25.1.0  # Use the latest stable version
+    hooks:
+    -   id: black
+
+-   repo: https://github.com/PyCQA/isort
+    rev: 6.0.0
+    hooks:
+    -   id: isort
+        name: isort (python)

CHANGES.md

@@ -0,0 +1,28 @@
+# Version History
+
+## Future Versions
+
+ - N/A
+
+## Upcoming Changes
+
+- Dropped support for Python 3.7 and 3.8
+- Fixed various Pylint warnings and errors:
+  - Added encoding to `open()` calls
+  - Replaced overly general exceptions with more specific ones
+  - Removed unused imports
+  - Fixed string formatting issues
+  - Added missing `timeout` parameter in `requests.get()` to prevent potential infinite waits
+  - Renamed parameter `license` to avoid conflict with built-in constant
+- Update upload, lint and test workflows
+- Add typing and documentation to the functions where it is missing
+- Add workflow to check for new entries in CHANGES.md file
+- Add CHANGES.md file
+
+## Current Version
+
+ - 2.0.5 (2024-01-11): Actions versions updated, supported Python versions updated, dependencies updated
+
+## Past Versions
+
+ - N/A

LICENSE

@@ -42,4 +42,3 @@ ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
 OTHER DEALINGS IN THE SOFTWARE.
 
 For more information, please refer to <http://unlicense.org>
-

README.md

@@ -21,12 +21,12 @@ And then use that package to get the URL of a judge's portrait. You can do that
 Or if you know the CourtListener ID for that judge, that works too (and is more reliable). Ketanji Jackson is ID 1609, so:
 
     >>> portrait(1609, ImageSizes.SMALL)
-    'https://portraits.free.law/v2/128/jackson-ketanji-1970.jpeg' 
+    'https://portraits.free.law/v2/128/jackson-ketanji-1970.jpeg'
 
 Now that you have the URL of the judge's photo in a useful size, just embed it in your application. Perhaps:
 
 ```html
-<img src="'https://portraits.free.law/v2/128/jackson-ketanji-1970.jpeg" 
+<img src="'https://portraits.free.law/v2/128/jackson-ketanji-1970.jpeg"
      height=128 />
 ```
 
@@ -59,7 +59,7 @@ That's about it.
 
 Very. It uses AWS S3 with CloudFront as a CDN. That gives us a LOT of nines.
 
-### What about versioning? 
+### What about versioning?
 
 Over time, we will be adding more photos to these collections. These will arrive as updates to the Python package and as new photos in the service. We expect these to be generally backwards compatible, but if we need to break compatibility, we will do so by bumping the Python package to version 3.x, and changing the URL of the images to contain v3 instead of v2.
 
@@ -79,7 +79,7 @@ Here's how we're thinking about it.
 
 The short answer is that our incentives are aligned with yours. Because our website uses this same service, it would be difficult for an attacker to put malicious photos on your website without them also appearing on ours. This service is included in our [vulnerability disclosure policy][vdp], and we use process and technical measures to prevent incidents.
 
-Because this service is hosted on S3, we do not manage servers and do not have to worry about things like expired HTTPS certificates, server vulnerabilities, etc. 
+Because this service is hosted on S3, we do not manage servers and do not have to worry about things like expired HTTPS certificates, server vulnerabilities, etc.
 
 In browsers, there is some discussion of a way to use cryptographic signatures to ensure the integrity of hotlinked images, but the feature has not seen much support. ([We're trying to nudge it along.][spec])
 

additional-sources.md

@@ -1,4 +1,4 @@
-In no particular order, the following locations are known to have judge 
+In no particular order, the following locations are known to have judge
 portraits. Some may be subject to copyright restriction. If so, I've made notes
 to that effect.
 
@@ -8,32 +8,32 @@ Federal Judicial Center
 The Federal Judicial Center (FJC) has a page with biographies and images here:
 
  - http://www.fjc.gov/history/home.nsf/page/judges.html
- 
+
 That shows biographies for a lot of federal judges and some of the biographies
-have images. 
+have images.
 
-I found some sort of file server here, where you can identify the images and 
+I found some sort of file server here, where you can identify the images and
 some meta data about them:
 
  - http://www.fjc.gov/history/portrait.nsf/lookup!OpenView&Start=1
- 
-To get these files, would probably require a fair amount of manual labor or a 
+
+To get these files, would probably require a fair amount of manual labor or a
 custom scraper, but there are about 200 that can be acquired.
 
 
 Philadelphia Courts
 -------------------
-The Philadelphia Courts have undertaken the collection of portraits and 
+The Philadelphia Courts have undertaken the collection of portraits and
 biographical information on their site:
 
  - http://www.courts.phila.gov/portraits/intro.asp
- 
+
 By browsing around, you can find another few hundred images, but the copyright
-on these is not clear as these are not works of the Federal Government. We are 
-looking into getting these images directly from the source with permission to 
+on these is not clear as these are not works of the Federal Government. We are
+looking into getting these images directly from the source with permission to
 use and re-use them.
 
-Note also that there are individual webpages that are easy to scrape: 
+Note also that there are individual webpages that are easy to scrape:
 
  - http://www.courts.phila.gov/portraits/bio.asp?P=9&keepThis=true&
 
@@ -44,11 +44,11 @@ This blog regularly posts portraits of judges from Minnesota that they have in
 their collection at the library:
 
  - http://ramseylawlibrary.org/?category_name=judicial-portraits
- 
-This would net about 30-40 portraits, but it may be worth contacting the 
+
+This would net about 30-40 portraits, but it may be worth contacting the
 library to see if they have more.
 
-Copyright on these images is not clear. We will need to get permission to use 
+Copyright on these images is not clear. We will need to get permission to use
 these.
 
 
@@ -58,24 +58,24 @@ These seven portraits might have been commissioned by the bar association or by
 the court:
 
  - http://www.cavcbar.net/html/photo_gallery.html
- 
+
 If by the court, then they're federal works and fair game. If not, then we need
 to reach out to the bar association and see if they can share these with us.
 
 There's currently a contact email address on the page:
 
  - cavcbarassoc@cavcbar.net
- 
+
 
 David Wells Roth
 ----------------
-This guy is a pro painter that makes portraits and posts them on his site. He 
-has a bunch for Puerto Rico, which he says they solicited him for. I get the 
+This guy is a pro painter that makes portraits and posts them on his site. He
+has a bunch for Puerto Rico, which he says they solicited him for. I get the
 sense that these are fair game since they were made for the Puerto Rico federal
 court:
 
  - http://davidwellsroth.com/portraits.html
- 
+
 Still: Probably a good idea to get in touch with him about the photos. There are
 about 40 photos here.
 
@@ -85,7 +85,7 @@ Pioneer Courthouse Galleries
 There is a collection of 10 9th Circuit Judges here:
 
  - http://pioneercourthouse.org/gallery-judges-portraits.html
- 
+
 These appear to be fair game, as this a federal court's website.
 
 
@@ -94,19 +94,19 @@ Portrait Presentations in the Supreme Court of North Carolina
 There are about 10 modern portraits here:
 
  - http://nccourts.org/Courts/Appellate/Supreme/Portrait/Default.asp
- 
+
 These are likely to have copyright restrictions.
 
 
 
 Texas Jurists Collection at the Tarlton Law Library
 ---------------------------------------------------
-This is a collection of about 400 judges, attorneys general and legal scholars: 
+This is a collection of about 400 judges, attorneys general and legal scholars:
 
  - https://www.lib.utexas.edu/taro/utlaw/00018/law-00018.html
- 
+
 It appears it has not been digitized online, however I believe it is available
-by reaching out to the library as I have seen some of the digital versions in 
+by reaching out to the library as I have seen some of the digital versions in
 other places.
 
 
@@ -115,7 +115,7 @@ Tarlton Law Library
 A collection of 160 judge portraits can be found:
 
  - http://tarlton.law.utexas.edu/justices/profile/portrait/160
- 
+
 Usage of these images may be challenging as different ones have different usage
 statements. However, the library as a whole has a CC Attribution License.
 
@@ -126,19 +126,19 @@ http://federalcircuithistoricalsociety.org/judges_ctcl.htm#2
 
 About 25 pics of Federal Circuit judges. The following attribution is requested:
 
-> These photographs are the property of the Federal Circuit Historical Society. 
-> Any reproduction of these photographs should acknowledge that they are being 
+> These photographs are the property of the Federal Circuit Historical Society.
+> Any reproduction of these photographs should acknowledge that they are being
 > reproduced with the "Courtesy of the Federal Circuit Historical Society.
 
 
 Assorted Other Sources
 ----------------------
-CA Superior Court: http://www.glenncourt.ca.gov/general_info/whoswho/judge.html  
-WA Supreme Court: http://www.courts.wa.gov/appellate_trial_courts/SupremeCourt/?fa=supremecourt.home&scRequest=members  
-CA8, but disorganized: http://www.lb8.uscourts.gov/pubsandservices/histsociety/hist_society.html  
-CA10, nice collection: http://www.10thcircuithistory.org/judge-bios-n-s/  
-MI, about 100 pics: http://www.micourthistory.org/justices/  
-NC, ~30 pics: http://www.ncschs.net/Justices_of_the_Court.aspx  
-KY, http://courts.ky.gov/courts/coa/Pages/coa.aspx and http://courts.ky.gov/courts/supreme/Pages/supremecourt.aspx  
+CA Superior Court: http://www.glenncourt.ca.gov/general_info/whoswho/judge.html
+WA Supreme Court: http://www.courts.wa.gov/appellate_trial_courts/SupremeCourt/?fa=supremecourt.home&scRequest=members
+CA8, but disorganized: http://www.lb8.uscourts.gov/pubsandservices/histsociety/hist_society.html
+CA10, nice collection: http://www.10thcircuithistory.org/judge-bios-n-s/
+MI, about 100 pics: http://www.micourthistory.org/justices/
+NC, ~30 pics: http://www.ncschs.net/Justices_of_the_Court.aspx
+KY, http://courts.ky.gov/courts/coa/Pages/coa.aspx and http://courts.ky.gov/courts/supreme/Pages/supremecourt.aspx
 
 You can also find lots of things by looking for historical societies.

judge_pics/__init__.py

@@ -1,11 +1,10 @@
 import json
 import os
 
-
 judge_root = os.path.abspath(
     os.path.join(os.path.realpath(__file__), "..", "data")
 )
 
 
-with open(os.path.join(judge_root, "people.json")) as f:
+with open(os.path.join(judge_root, "people.json"), encoding="utf-8") as f:
     judge_pics = json.load(f)

judge_pics/data/people.json

@@ -11240,4 +11240,4 @@
     "person": 9707,
     "source": "Provided by the Judiciary of Tennessee"
   }
-]
+]