Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RFC 8908 captive portal API JSON #466

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Add RFC 8908 captive portal API JSON #466

merged 1 commit into from
Jan 8, 2025

Conversation

T0biii
Copy link
Member

@T0biii T0biii commented Jan 1, 2025 •
edited
Loading

@T0biii T0biii requested a review from a team as a code owner January 1, 2025 00:27
@DasSkelett DasSkelett changed the title add captive Add RFC 8908 captive portal API JSON Jan 3, 2025
@T0biii T0biii mentioned this pull request Jan 7, 2025
Merged
@herbetom
Copy link
Contributor

herbetom commented Jan 7, 2025 •
edited
Loading

As far as i remember it's important that the Type is set to application/captive+json.

For comparison:
https://git.darmstadt.ccc.de/ffda/infra/salt/-/commit/1914b96b354a7a429c577c50ffd7bf9598b0cd0a
https://git.darmstadt.ccc.de/ffda/infra/salt/-/commit/5d63b8bc5f06e49a98d59a2c0ad06d6e4aed84fb

Edit: I've added the type to freifunkMUC/ffmuc-salt-public#176

@T0biii T0biii enabled auto-merge January 8, 2025 06:34
@T0biii T0biii merged commit a378aba into main Jan 8, 2025
2 checks passed
@T0biii T0biii deleted the add-captive branch January 8, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoliathLabs GoliathLabs GoliathLabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@T0biii @herbetom @GoliathLabs