fix: checks if element exists before reading height #4590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarni
requested review from
piofinn,
zenabii,
kristianulv23,
olejorgenbakken,
fremtindelise and
Chrihenn
Fixes an error that would sometimes get thrown if the element we tried to read the height from was no longer in the DOM.
ivarni
force-pushed
the
handle-possibly-empty-ref
branch
from
6a6a726 to
8870bb1
Compare
|
✅ Forhåndsvisning: https://jokul.fremtind.no/preview/handle-possibly-empty-ref/ Forhåndsvisningen blir tilgjengelig innen et par minutter. Den fjernes automatisk når pull requesten lukkes. |
fremtind-bot
added a commit
that referenced
this pull request
Feb 21, 2025
fremtind-bot
added a commit
that referenced
this pull request
Feb 21, 2025
kristianulv23
approved these changes
Feb 24, 2025
piofinn
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error that would sometimes get thrown if the element we tried to read the height from was no longer in the DOM.
🎯 Sjekkliste
pnpm buildogpnpm ci:testgir ingen feil