Skip to content

Commit a53a0f5

Browse files
fix: update computed props to missing profile details and add job title details
1 parent 589ff10 commit a53a0f5

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

packages/frontendmu-data/data/speakers-profile.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"bio": "Front-End Engineer | Streamer (Twitch)",
1212
"job_title": "Senior Front-end Engineer @ Livestorm",
1313
"location": "Mauritius",
14+
"website": "",
1415
"github": "cedpoilly",
1516
"twitter": ""
1617
}

packages/frontendmu-nuxt/components/speaker/Single.vue

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,12 @@ const person = computed(() => props.speaker.person)
1616
const sessions = computed(() => props.speaker.sessions)
1717
1818
const profile = computed(() => props.speaker.profile)
19-
const hasProfileBio = computed(() => profile.value.bio !== '')
20-
const hasProfileLocation = computed(() => profile.value.location !== '')
21-
const hasProfileWebsite = computed(() => profile.value.website !== '')
22-
const hasProfileGithub = computed(() => profile.value.github !== '')
23-
const hasProfileTwitter = computed(() => profile.value.twitter !== '')
19+
const hasProfileBio = computed(() => profile.value.bio && profile.value.bio !== '')
20+
const hasProfileJobTitle = computed(() => profile.value.job_title && profile.value.job_title !== '')
21+
const hasProfileLocation = computed(() => profile.value.location && profile.value.location !== '')
22+
const hasProfileWebsite = computed(() => profile.value.website && profile.value.website !== '')
23+
const hasProfileGithub = computed(() => profile.value.github && profile.value.github !== '')
24+
const hasProfileTwitter = computed(() => profile.value.twitter && profile.value.twitter !== '')
2425
2526
const speaker_photo = getGithubUrl(person.value.github_account)
2627
</script>
@@ -94,6 +95,10 @@ const speaker_photo = getGithubUrl(person.value.github_account)
9495
</p>
9596

9697
<nav class="grid gap-2 *:flex *:justify-start *:items-center *:gap-2">
98+
<span v-if="hasProfileJobTitle">
99+
<Icon name="lucide:code-xml" mode="svg" class="size-6" />{{ profile.job_title }}
100+
</span>
101+
97102
<span v-if="hasProfileLocation">
98103
<Icon name="lucide:map-pin" mode="svg" class="size-6" />{{ profile.location }}
99104
</span>

0 commit comments

Comments
 (0)