Bug: Fixed regression from the fix made in #146 #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thx for noticing and for sending the fix ! 🙏 colors look good. i'm thinking we should reorganize the layout a bit so that we show "events" above the fold when the page loads. for now this will do. i'll try to come up with another layout for the homepage soon. merging ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix made in the
isUpcomingfunction in issue #146 impacted the display of meetups in the sectionNext Meetup,Upcoming MeetupsandRecent MeetupsScreenshots for better understanding 👇
This happened since the condition was inverted in other places using the
isUpcomingfunction.This PR fixes the issue. Please have a look whether the colors are correct. @MrSunshyne 🙏