Skip to content

#158 Bug: Attempt to fix contributors not being updated on the website #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

the-code-raider
Copy link
Contributor

@the-code-raider the-code-raider commented Aug 3, 2024

I noticed that the contributors section were not being updated.
Up on further investigation, it seems that the url https://api.github.com/repos/Front-End-Coders-Mauritius/frontendmu.mu/contributors found in the update-contributors.js script results in the below 👇

image

I applied a fix by changing frontendmu.mu to frontend.mu. However, I was unable to test.

@MrSunshyne Could you please have a look? 🙏

Fixes #158

@the-code-raider the-code-raider changed the title Attempt to fix contributors not being updated on the website #158 Attempt to fix contributors not being updated on the website Aug 3, 2024
@the-code-raider the-code-raider changed the title #158 Attempt to fix contributors not being updated on the website #158 Bug: Attempt to fix contributors not being updated on the website Aug 3, 2024
@MrSunshyne
Copy link
Member

that's hilarious xD

testing now

@MrSunshyne
Copy link
Member

This resolves the issue! thanks a lot for noticing and sending the PR @the-code-raider !

For info, this command is run during the CI, but you can also test it locally. Because we're using a monorepo, the update contributors script is ran in the "data" package but we use it in the "nuxt" package and display it on the on the /team page.

To run the script from the root of the repository you can do:

pnpm run data update-contributors

Warning

This script will change your global git username and email to "GitHub Action" and "action @ github.com".
Remember to revert that, if you ever run this script locally.

@MrSunshyne MrSunshyne merged commit 1dc11ff into frontendmu:main Aug 3, 2024
1 check passed
@the-code-raider
Copy link
Contributor Author

Thanks for the explanation! 🙌 I will keep it in mind. 😊

@the-code-raider
Copy link
Contributor Author

@MrSunshyne I checked the update contributors actions and looking at the logs, the Update Contributors nuxt stage seems to throw an error. Maybe you've an idea?

Screenshot 👇 Link

Screenshot from 2024-08-03 20-15-17

@MrSunshyne
Copy link
Member

MrSunshyne commented Aug 3, 2024

@the-code-raider i'm not sure why the git command failed. as the exact same command passed in the astro update contributors.

I removed the need to install nuxt dependencies during the GH Action CI, as the nuxt build happens on cloudflare pages.

The action is now muchhh faster. 20s (previously >65s)

Seems to work now. I see the new numbers on the production website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributors not updating
2 participants