Skip to content

Filter the github-actions[bot] from the contributors list #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

derecklhw
Copy link
Contributor

No description provided.

@MrSunshyne
Copy link
Member

@derecklhw the filtering should be done indeed but not in this file, but rather at the source when we're writing the contributors json file. See here: https://github.com/Front-End-Coders-Mauritius/frontend.mu/blob/main/packages/frontendmu-data/scripts/update-contributors.js#L25

Copy link
Member

@MrSunshyne MrSunshyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the filtering to the data package instead of in the nuxt component

@derecklhw
Copy link
Contributor Author

derecklhw commented Aug 26, 2024

@MrSunshyne do we exclude just GitHub Action[bot] or both it and the new username GitHub Action ?

const excludedContributors = ["actions-user", "GitHub Action[bot]", "GitHub Action"];

@MrSunshyne
Copy link
Member

@derecklhw correct, we exclude all 3 of them. So your idea to maintain an excludeList looks good! go for it

@MrSunshyne MrSunshyne merged commit aca1477 into frontendmu:main Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants