fix: GitHub references from old Front-End-Coders-Mauritius to frontendmu #249
Conversation
fix: github author attribution link on team page
WalkthroughThe changes primarily involve updates to various components and configuration files to modify GitHub repository URLs. The Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| @@ -197,7 +197,7 @@ onMounted(toggleHeader); | |||
| </nav> | |||
| <div> | |||
| <div class="flex items-center gap-2"> | |||
| <!-- <a target="_blank" href="https://github.com/Front-End-Coders-Mauritius"> | |||
| <!-- <a target="_blank" href="hhttps://github.com/frontendmu/frontend.mu/"> | |||
There was a problem hiding this comment.
Thanks! I've updated it.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (3)
packages/frontendmu-astro/src/components/HomeSocialPresence.astro (1)
31-31: Consider updating the description text.The description "The home of FEC projects" still uses the old "FEC" abbreviation. Consider updating it to align with the new branding, for example: "The home of Frontend Mauritius projects".
- <p slot="description">The home of FEC projects</p> + <p slot="description">The home of Frontend Mauritius projects</p>packages/frontendmu-nuxt/components/site/Menu.vue (1)
Line range hint
200-204: Fix typo in commented GitHub URL.There's a typo in the commented GitHub URL - it contains a double 'h' in "hhttps://".
Apply this fix:
- <!-- <a target="_blank" href="hhttps://github.com/frontendmu/frontend.mu/"> + <!-- <a target="_blank" href="https://github.com/frontendmu/frontend.mu/">Consider also adding the
?ref=frontend.muparameter for consistency with other GitHub links in the codebase.packages/frontendmu-astro/src/components/TeamComponent.astro (1)
Line range hint
31-31: Fix duplicate HTML IDs.Both unordered lists use the same ID "team". HTML IDs must be unique within the document.
Apply this diff to fix the duplicate IDs:
- <ul - id="team" + <ul + id="people" role="list" class="mx-auto grid grid-cols-2 gap-x-4 gap-y-8 sm:grid-cols-4 md:gap-x-6 lg:gap-x-8" > <!-- ... --> - <ul - id="team" + <ul + id="speakers" role="list" class="mx-auto grid grid-cols-2 gap-x-4 gap-y-8 sm:grid-cols-5 md:gap-x-6 lg:gap-x-8" >Also applies to: 108-108
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (8)
- cliff.toml (1 hunks)
- packages/frontendmu-astro/src/components/HomeSocialPresence.astro (1 hunks)
- packages/frontendmu-astro/src/components/MainMenu.astro (1 hunks)
- packages/frontendmu-astro/src/components/MegaMenu.astro (2 hunks)
- packages/frontendmu-astro/src/components/TeamComponent.astro (1 hunks)
- packages/frontendmu-nuxt/components/home/SocialPresence.vue (1 hunks)
- packages/frontendmu-nuxt/components/site/Menu.vue (2 hunks)
- packages/frontendmu-nuxt/pages/team.vue (1 hunks)
🔇 Additional comments (9)
packages/frontendmu-astro/src/components/HomeSocialPresence.astro (1)
28-28: LGTM! GitHub URL updated correctly.The URL change aligns with the PR objective of updating references from Front-End-Coders-Mauritius to frontendmu.
packages/frontendmu-nuxt/components/home/SocialPresence.vue (2)
25-25: LGTM! Verify the new GitHub organization URL.The URL update aligns with the PR objectives to change references from Front-End-Coders-Mauritius to frontendmu.
Let's verify the new GitHub organization exists and is accessible:
✅ Verification successful
GitHub organization URL change verified successfully
The new GitHub organization URL (https://github.com/frontendmu) is accessible and valid, confirming the URL update in the component is correct.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the new GitHub organization exists and is accessible # Expected: Should return HTTP 200 if the organization exists curl -s -o /dev/null -w "%{http_code}" https://github.com/frontendmuLength of output: 74
25-25: Check for broken relative links within the organization.Since the GitHub organization URL has changed, ensure that any relative links (e.g., to specific repositories, issues, or documentation) within the organization are still valid.
Let's search for any other GitHub-related links that might need updates:
cliff.toml (1)
Line range hint
1-89: Verify changelog generation still works as expected.The URL change affects how links are generated in the changelog for version comparisons, commits, and issues. While the change is straightforward, it's important to ensure the changelog generation still functions correctly.
Let's verify the changelog format by checking recent releases:
#!/bin/bash # Description: Check recent CHANGELOG.md entries to ensure proper link generation # Expected: Links should use the new 'frontendmu' URL format if [ -f CHANGELOG.md ]; then echo "=== Checking recent changelog entries ===" head -n 20 CHANGELOG.md else echo "CHANGELOG.md not found" fipackages/frontendmu-nuxt/pages/team.vue (2)
96-96: LGTM! GitHub repository reference updated correctly.The URL has been properly updated to use the new repository name
frontendmu/frontend.mu.
96-96: Verify other GitHub URL references in the codebase.Let's ensure all GitHub repository references have been updated consistently.
✅ Verification successful
GitHub repository references have been updated consistently
The search results confirm that all GitHub repository references in the codebase are using the new organization name "frontendmu" consistently. The only references to GitHub URLs are:
- Profile images using github.com/{username}.png
- Repository links using github.com/frontendmu
- Commit history links using github.com/frontendmu/frontend.mu/commits
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any remaining references to the old repository name echo "Searching for old repository references..." rg -i "Front-End-Coders-Mauritius" --type-not git # Check the implementation of getGithubUrl helper echo -e "\nChecking getGithubUrl implementation..." fd -e ts -e js "helpers" --exec rg -l "getGithubUrl"Length of output: 362
Script:
#!/bin/bash # Let's check the content of helpers.ts and search for GitHub URLs in the codebase echo "Content of helpers.ts:" cat ./packages/frontendmu-nuxt/utils/helpers.ts echo -e "\nSearching for GitHub URLs in the codebase:" rg -i "github.com/[^/\"']+" --type-not git echo -e "\nSearching specifically for frontendmu references:" rg -i "github.com/frontendmu" --type-not gitLength of output: 4752
Script:
#!/bin/bash # Let's try a different approach to search for GitHub URLs echo "Searching for GitHub URLs in all files:" rg -i "github\.com" --type html --type typescript --type javascript --type vue echo -e "\nSearching for repository references:" rg -i "frontend\.mu/|frontendmu/" --type html --type typescript --type javascript --type vueLength of output: 423
Script:
#!/bin/bash # Search for GitHub URLs without specifying file types echo "Searching for GitHub URLs in all files:" rg -i "github\.com" echo -e "\nSearching for specific GitHub repository references:" rg -i "frontend\.mu/commits|frontendmu/frontend\.mu/commits"Length of output: 275316
packages/frontendmu-nuxt/components/site/Menu.vue (1)
70-70: LGTM! GitHub organization link updated correctly.The GitHub organization URL has been properly updated to reflect the new repository structure while maintaining the referral parameter.
packages/frontendmu-astro/src/components/TeamComponent.astro (1)
156-156: LGTM! URL update aligns with repository migration.The GitHub URL has been correctly updated to reflect the new repository structure.
Let's verify if there are any other GitHub references that need updating:
✅ Verification successful
GitHub URL update verified, no remaining references to old repository
The verification confirms:
- No instances of "front-end-coders-mauritius" remain in the TeamComponent
- Only one GitHub URL exists, which correctly uses the new "frontendmu" organization
- The
getGithubUrlutility only handles avatar URLs and doesn't contain repository-specific paths🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any remaining old GitHub references rg -i "front-end-coders-mauritius" --type astro # Check the getGithubUrl utility implementation ast-grep --pattern 'function getGithubUrl($_) { $$$ }'Length of output: 641
Script:
#!/bin/bash # Search for any remaining old GitHub references with correct file type rg -i "front-end-coders-mauritius" packages/frontendmu-astro/src/components/TeamComponent.astro # Check for all GitHub URLs in the TeamComponent rg -i "github.com" packages/frontendmu-astro/src/components/TeamComponent.astroLength of output: 276
packages/frontendmu-astro/src/components/MegaMenu.astro (1)
52-52: LGTM! GitHub URL updated correctly.The GitHub URL has been properly updated to the new organization name while maintaining the ref parameter.
| @@ -26,7 +26,7 @@ const links = { | |||
| }, | |||
| github: { | |||
| title: "Github", | |||
| href: "https://github.com/Front-End-Coders-Mauritius", | |||
| href: "https://github.com/frontendmu", | |||
There was a problem hiding this comment.
💡 Codebase verification
Update required: Old organization references found in active code
Several files still reference the old GitHub organization and need to be updated:
-
Update scripts to use new organization name:
- packages/frontendmu-data/scripts/update-contributors.js
- packages/frontendmu-astro/automation/update-contributors.js
-
Update photo album source URLs:
- packages/frontendmu-data/scripts/directus-dump.js
- packages/frontendmu-nuxt/app.config.ts
- packages/frontendmu-astro/scripts/directus-dump.js
- packages/frontendmu-astro/src/config.ts
- packages/frontendmu-astro/src/components/Meetup.vue
The google-photos-sync repository needs to be migrated to the new organization to maintain functionality.
🔗 Analysis chain
LGTM! Verify URL consistency across codebase.
The GitHub URL update aligns with the PR objectives. The link functionality and external link handling remain intact.
Let's verify the consistency of the new GitHub URL across the codebase:
Based on the search results, I can see that there are still some references to the old GitHub organization "Front-End-Coders-Mauritius" in several files, particularly in:
- config.ts and Meetup.vue files referencing "google-photos-sync" repository
- meetups-raw.json containing historical data with image URLs
Let me verify if these are the only remaining references and if they are part of active code or just historical data.
Let me modify the search to avoid file type restrictions since the file types are not recognized.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any remaining references to the old GitHub organization
# and ensure consistency of the new URL format
echo "Checking for old GitHub organization references..."
rg -i "Front-End-Coders-Mauritius"
echo -e "\nVerifying consistency of new GitHub URL format..."
rg -i "github.com/frontendmu"
Length of output: 503580
Script:
#!/bin/bash
# Check if the old references are in active code paths or just data files
echo "Checking config files and components..."
rg -i "Front-End-Coders-Mauritius" --type ts --type vue
echo -e "\nChecking if the new URL format is consistently used in active code..."
rg -i "github\.com/[^/]*frontendmu" --type ts --type vue --type astro
Length of output: 427
Script:
#!/bin/bash
# Check active code paths for old and new GitHub URLs
echo "Checking for old organization references in code files..."
rg -i "Front-End-Coders-Mauritius" -g "*.{ts,js,vue,astro}"
echo -e "\nChecking new URL format usage in code files..."
rg -i "github\.com/[^/]*frontendmu" -g "*.{ts,js,vue,astro}"
Length of output: 2439
cliff.toml
Outdated
| @@ -43,7 +43,7 @@ body = """ | |||
| trim = true | |||
| # postprocessors | |||
| postprocessors = [ | |||
| { pattern = '<REPO>', replace = "https://github.com/Front-End-Coders-Mauritius/frontend.mu" }, # replace repository URL | |||
| { pattern = '<REPO>', replace = "https://github.com/frontendmu/frontend.mu" }, # replace repository URL | |||
There was a problem hiding this comment.
💡 Codebase verification
URL update needs attention - old URL still in use
The URL change in the postprocessors section is correct, but there's an inconsistency in the configuration. The old organization URL is still being used in the commit_preprocessors section where <REPO> is used for issue links. This needs to be updated for consistency.
- Line 46: ✅
{ pattern = '<REPO>', replace = "https://github.com/frontendmu/frontend.mu" } - Line 63: ❌ Still using
<REPO>placeholder which gets replaced with the old URL pattern
🔗 Analysis chain
LGTM! URL update aligns with organization changes.
The repository URL update from 'Front-End-Coders-Mauritius' to 'frontendmu' is consistent with the PR objectives.
Let's verify no other instances of the old URL exist in the file:
Let me verify the changelog configuration file itself to ensure we have a complete picture:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any remaining instances of the old organization name
# Expected: No matches should be found
rg -i "Front-End-Coders-Mauritius" cliff.toml
Length of output: 1200
Script:
#!/bin/bash
# Check the content of cliff.toml to see all URL patterns and replacements
cat cliff.toml
Length of output: 3336
| @@ -75,7 +75,7 @@ const links: TMenu = { | |||
| }, | |||
| github: { | |||
| title: "Github", | |||
| href: "https://github.com/Front-End-Coders-Mauritius", | |||
| href: "https://github.com/frontendmu", | |||
There was a problem hiding this comment.
💡 Codebase verification
Let me analyze the search results to verify the GitHub URL update consistency:
GitHub URL references need to be updated in several files
The following locations still contain references to the old organization name:
packages/frontendmu-data/scripts/update-contributors.js: Contains old organization name in variablepackages/frontendmu-data/data/featured-issues.json: Contains multiple issue URLs with old organizationpackages/frontendmu-data/scripts/directus-dump.js: Contains old organization name in photo album sourceCHANGELOG.md: Contains multiple commit URLs with old organization name
The new organization name "frontendmu" is correctly used in:
- Menu components
- Social presence components
- Team components
- Configuration files
🔗 Analysis chain
LGTM! GitHub URL updated correctly.
The GitHub URL has been properly updated to the new organization name.
Let's verify the consistency of GitHub URL updates across the codebase:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any remaining references to the old GitHub organization
# Test: Search for any remaining instances of the old organization name
echo "Checking for remaining old GitHub references..."
rg -i "Front-End-Coders-Mauritius"
# Test: Verify the new organization name is used consistently
echo -e "\nVerifying new GitHub references..."
rg -i "github.com/frontendmu"
Length of output: 503544
|
most of the team was away last week :P thanks for much for the PR @cbillowes |
There are numerous references to https://github.com/Front-End-Coders-Mauritius on the website. This PR proposes an update to all references on the website.
An additional sweep is required to updated Gists and other references I am not familiar with.
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Chores