Skip to content

fix: GitHub references from old Front-End-Coders-Mauritius to frontendmu #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 9, 2024
Merged

fix: GitHub references from old Front-End-Coders-Mauritius to frontendmu #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5aafb9f
fix: github author attribution link on team page
cbillowes Oct 28, 2024
228daf8
fix: github link in home social presence
cbillowes Oct 28, 2024
8bcd20e
fix: simple github links
cbillowes Oct 28, 2024
eef2501
fix: (with caution) invalid github link on cliff.toml
cbillowes Oct 28, 2024
d7ff330
fix: remove duplicate h in https
cbillowes Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cliff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ body = """
trim = true
# postprocessors
postprocessors = [
{ pattern = '<REPO>', replace = "https://github.com/Front-End-Coders-Mauritius/frontend.mu" }, # replace repository URL
{ pattern = '<REPO>', replace = "https://github.com/frontendmu/frontend.mu" }, # replace repository URL
]

[git]
Expand Down
2 changes: 1 addition & 1 deletion packages/frontendmu-astro/src/components/HomeSocialPresence.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import IconLinkedin from "./icons/icon-linkedin.astro";
</SocialCard>

<SocialCard
href="https://github.com/Front-End-Coders-Mauritius"
href="https://github.com/frontendmu"
class="bg-[#333] text-sm md:text-normal"
>
<p slot="tagline">GitHub</p>
Expand Down
2 changes: 1 addition & 1 deletion packages/frontendmu-astro/src/components/MainMenu.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const links = {
},
github: {
title: "Github",
href: "https://github.com/Front-End-Coders-Mauritius",
href: "https://github.com/frontendmu",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Update required: Old organization references found in active code

Several files still reference the old GitHub organization and need to be updated:

  • Update scripts to use new organization name:

    • packages/frontendmu-data/scripts/update-contributors.js
    • packages/frontendmu-astro/automation/update-contributors.js

  • Update photo album source URLs:

    • packages/frontendmu-data/scripts/directus-dump.js
    • packages/frontendmu-nuxt/app.config.ts
    • packages/frontendmu-astro/scripts/directus-dump.js
    • packages/frontendmu-astro/src/config.ts
    • packages/frontendmu-astro/src/components/Meetup.vue

The google-photos-sync repository needs to be migrated to the new organization to maintain functionality.

🔗 Analysis chain

LGTM! Verify URL consistency across codebase.

The GitHub URL update aligns with the PR objectives. The link functionality and external link handling remain intact.

Let's verify the consistency of the new GitHub URL across the codebase:

Based on the search results, I can see that there are still some references to the old GitHub organization "Front-End-Coders-Mauritius" in several files, particularly in:

  1. config.ts and Meetup.vue files referencing "google-photos-sync" repository
  2. meetups-raw.json containing historical data with image URLs

Let me verify if these are the only remaining references and if they are part of active code or just historical data.

Let me modify the search to avoid file type restrictions since the file types are not recognized.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any remaining references to the old GitHub organization
# and ensure consistency of the new URL format

echo "Checking for old GitHub organization references..."
rg -i "Front-End-Coders-Mauritius"

echo -e "\nVerifying consistency of new GitHub URL format..."
rg -i "github.com/frontendmu"

Length of output: 503580

Script:

#!/bin/bash
# Check if the old references are in active code paths or just data files
echo "Checking config files and components..."
rg -i "Front-End-Coders-Mauritius" --type ts --type vue

echo -e "\nChecking if the new URL format is consistently used in active code..."
rg -i "github\.com/[^/]*frontendmu" --type ts --type vue --type astro

Length of output: 427

Script:

#!/bin/bash
# Check active code paths for old and new GitHub URLs
echo "Checking for old organization references in code files..."
rg -i "Front-End-Coders-Mauritius" -g "*.{ts,js,vue,astro}"

echo -e "\nChecking new URL format usage in code files..."
rg -i "github\.com/[^/]*frontendmu" -g "*.{ts,js,vue,astro}"

Length of output: 2439

class: "hidden md:block",
},
};
Expand Down
4 changes: 2 additions & 2 deletions packages/frontendmu-astro/src/components/MegaMenu.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const links: TMenu = {
},
{
title: "GitHub",
href: "https://github.com/Front-End-Coders-Mauritius?ref=frontend.mu",
href: "https://github.com/frontendmu?ref=frontend.mu",
class: "",
},
{
Expand All @@ -75,7 +75,7 @@ const links: TMenu = {
},
github: {
title: "Github",
href: "https://github.com/Front-End-Coders-Mauritius",
href: "https://github.com/frontendmu",
class: "hidden md:block",
},
};
Expand Down
2 changes: 1 addition & 1 deletion packages/frontendmu-astro/src/components/TeamComponent.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ const contributors: Contributor[] = Contributors;
return (
<li>
<a
href={`https://github.com/Front-End-Coders-Mauritius/frontendmu-astro/commits?author=${person.username}`}
href={`https://github.com/frontendmu/frontend.mu/commits?author=${person.username}`}
target="_blank"
class="space-y-4"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/frontendmu-nuxt/components/home/SocialPresence.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
</template>
</HomeSocialCard>

<HomeSocialCard href="https://github.com/Front-End-Coders-Mauritius" class="bg-[#333] text-sm md:text-normal">
<HomeSocialCard href="https://github.com/frontendmu" class="bg-[#333] text-sm md:text-normal">
<template #tagline>
<p>GitHub</p>
</template>
Expand Down
4 changes: 2 additions & 2 deletions packages/frontendmu-nuxt/components/site/Menu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const links: TMenu = {
},
{
title: "GitHub",
href: "https://github.com/Front-End-Coders-Mauritius?ref=frontend.mu",
href: "https://github.com/frontendmu?ref=frontend.mu",
class: "",
},
{
Expand Down Expand Up @@ -197,7 +197,7 @@ onMounted(toggleHeader);
</nav>
<div>
<div class="flex items-center gap-2">
<!-- <a target="_blank" href="https://github.com/Front-End-Coders-Mauritius">
<!-- <a target="_blank" href="https://github.com/frontendmu/frontend.mu/">
<span class="sr-only">GitHub Repository</span>
<Icon name="carbon:logo-github" class="w-4 h-4 text-verse-600 dark:text-verse-100" />
</a> -->
Expand Down
2 changes: 1 addition & 1 deletion packages/frontendmu-nuxt/pages/team.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const NuxtLink = resolveComponent('NuxtLink')

<ul id="team" role="list" class="mx-auto grid grid-cols-2 gap-x-4 gap-y-8 sm:grid-cols-4 md:gap-x-6 lg:gap-x-8">
<li v-for="person in contributors" :key="person.username">
<a :href="`https://github.com/Front-End-Coders-Mauritius/frontendmu-astro/commits?author=${person.username}`"
<a :href="`https://github.com/frontendmu/frontend.mu/commits/?author=${person.username}`"
target="_blank" class="space-y-4">
<img
class="mx-auto h-20 w-20 rounded-full border-verse-2 shadow-lg 00 border p-2 lg:w-48 lg:h-48 profile-avatar"
Expand Down
Loading