-
Notifications
You must be signed in to change notification settings - Fork 25
feat: add n-d-r-d-g to speakers-profile.json #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new speaker profile entry has been added to the JSON array in the Changes
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying frontend-mu-nuxt with
|
Latest commit: |
041ca87
|
Status: | ✅ Deploy successful! |
Preview URL: | https://c758598f.frontend-mu-staging.pages.dev |
Branch Preview URL: | https://update-speaker-profile.frontend-mu-staging.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/frontendmu-data/data/speakers-profile.json (1)
17-17
: Trailing Comma Addition Consistency.
The tilde-marked line 17 now shows the closing brace of the second speaker profile with a trailing comma. This change correctly separates JSON objects in the array. Please confirm that this formatting aligns with your project's JSON style guidelines.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/frontendmu-data/data/speakers-profile.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Cloudflare Pages: frontend-mu-nuxt
🔇 Additional comments (1)
packages/frontendmu-data/data/speakers-profile.json (1)
18-24
: New Speaker Profile Entry Validation.
The newly added profile for "n-d-r-d-g" includes all the expected fields (bio
,job_title
,location
,website
,github
, and
This PR adds my profile to speakers-profile.json.
Summary by CodeRabbit