Skip to content

Update requirements.txt #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update requirements.txt #958

wants to merge 1 commit into from

Conversation

piskunow
Copy link

@piskunow piskunow commented Apr 1, 2025

Fix #957

@martindurant
Copy link
Member

Are you having problems with the current syntax? 2025.3.2.* does indeed match 2025.3.2

@piskunow
Copy link
Author

piskunow commented Apr 1, 2025

The matching depends on the parser.

There is no release version fsspec==2025.3.2.XYZ, which may confuse some parsers.

This version specification is not the common pattern. See https://peps.python.org/pep-0440/ (they outline a possible regex parser for versions).

@martindurant
Copy link
Member

Which parsers do you have in mind aside from pip?
Note that the PEP link specifically does have four component versions, and adds that extra "*" is also permitted.

Having said that, I don't recall why the version bound became like this. Perhaps others will see this thread and comment.

@jykae
Copy link

jykae commented Apr 14, 2025

@piskunow @martindurant Verified that 2024.3.1 is the latest working version, hope you could fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fsspec==2025.3.2.* does not exist
3 participants