Fixed Sonar issues

Author: michael-schnell

src/main/java/org/fuin/utils4j/jandex/JandexIndexFileReader.java

@@ -62,8 +62,8 @@ private IndexView loadFile(final File file) throws IOException {
     private IndexView loadResources(final String indexFilePathAndName) throws IOException {
         final Enumeration<URL> enu = Thread.currentThread().getContextClassLoader().getResources(indexFilePathAndName);
         final List<IndexView> indexes = new ArrayList<>();
-        final List<URL> resources = Collections.list(enu);
-        for (final URL url : resources) {
+        final List<URL> urlList = Collections.list(enu);
+        for (final URL url : urlList) {
             try (final InputStream input = url.openStream()) {
                 indexes.add(new IndexReader(input).read());
             }

src/main/java/org/fuin/utils4j/jandex/JandexIndexFileWriter.java

@@ -3,11 +3,6 @@
 import org.jboss.jandex.*;
 
 import java.io.*;
-import java.net.URL;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.Enumeration;
-import java.util.List;
 
 /**
  * Helps to write Jandex index files.

src/main/java/org/fuin/utils4j/jaxb/JaxbUtils.java

@@ -223,7 +223,7 @@ public static <T> T unmarshal(final String xmlData, final Class<?>... classesToB
         if (classesToBeBound != null) {
             builder.addClassesToBeBound(classesToBeBound);
         }
-        builder.withHandler(event -> { return false; });        	
+        builder.withHandler(event -> false);
         return unmarshal(builder.build(), xmlData);
     }
 
@@ -251,7 +251,7 @@ public static <T> T unmarshal(final String xmlData, final XmlAdapter<?, ?>[] ada
             builder.addClassesToBeBound(classesToBeBound);
         }
         builder.addAdapters(adapters);
-        builder.withHandler(event -> { return false; });        	
+        builder.withHandler(event -> false);
         return unmarshal(builder.build(), xmlData);
     }
 
@@ -278,7 +278,7 @@ public static <T> T unmarshal(final JAXBContext ctx, final String xmlData, final
         if (adapters != null) {
         	builder.addAdapters(adapters);
         }
-        builder.withHandler(event -> { return false; });        	
+        builder.withHandler(event -> false);
         return unmarshal(builder.build(), xmlData);
     }
 
@@ -305,7 +305,7 @@ public static <T> T unmarshal(final JAXBContext ctx, final Reader reader, final
         if (adapters != null) {
             builder.addAdapters(adapters);
         }
-        builder.withHandler(event -> { return false; });        	
+        builder.withHandler(event -> false);
         return unmarshal(builder.build(), reader);
     }
 

src/main/java/org/fuin/utils4j/jaxb/MarshallerBuilder.java

@@ -29,8 +29,6 @@ public class MarshallerBuilder {
 
     private ValidationEventHandler handler;
 
-    private boolean formattedOutput;
-
     private JAXBContext ctx;
 
 

src/test/java/org/fuin/utils4j/fileprocessor/FileProcessorTest.java

@@ -17,7 +17,6 @@
  */
 package org.fuin.utils4j.fileprocessor;
 
-import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.Test;
 
 import java.io.File;

src/test/java/org/fuin/utils4j/jandex/JandexIndexFileReaderTest.java

@@ -17,10 +17,8 @@
  */
 package org.fuin.utils4j.jandex;
 
-import org.fuin.utils4j.jandex.JandexIndexFileReader;
 import org.fuin.utils4j.jandex.JandexIndexFileReader.Builder;
 
-import org.fuin.utils4j.jandex.JandexUtils;
 import org.jboss.jandex.IndexView;
 import org.junit.jupiter.api.Test;
 

src/test/java/org/fuin/utils4j/jandex/JandexIndexFileWriterTest.java

@@ -37,8 +37,6 @@ public class JandexIndexFileWriterTest {
 
     private static final File TARGET_DIR = new File("target");
 
-    private static final File CLASSES_DIR = new File(TARGET_DIR, "classes");
-
     private static final File TEST_CLASSES_DIR = new File(TARGET_DIR, "test-classes");
 
     @Test

src/test/java/org/fuin/utils4j/jandex/JandexUtilsTest.java

@@ -42,8 +42,6 @@ public class JandexUtilsTest {
 
     private static final File CLASSES_DIR = new File(TARGET_DIR, "classes");
 
-    private static final File TEST_CLASSES_DIR = new File(TARGET_DIR, "test-classes");
-
     @Test
     public final void testIndexClassFile() {
 

src/test/java/org/fuin/utils4j/jaxb/MarshallerBuilderTest.java

@@ -19,11 +19,9 @@
 
 import jakarta.xml.bind.JAXBContext;
 import jakarta.xml.bind.JAXBException;
-import jakarta.xml.bind.MarshalException;
 import jakarta.xml.bind.Marshaller;
 import jakarta.xml.bind.annotation.adapters.XmlAdapter;
 import org.junit.jupiter.api.Test;
-import org.xml.sax.SAXParseException;
 import org.xmlunit.builder.DiffBuilder;
 import org.xmlunit.diff.Diff;
 
@@ -201,9 +199,11 @@ public void testWithListener() throws JAXBException {
         final AtomicBoolean afterCalled = new AtomicBoolean(false);
         final Marshaller marshaller = new MarshallerBuilder().withContext(ctx).addAdapters(new MyId.Adapter())
                 .withListener(new Marshaller.Listener() {
+                    @Override
                     public void beforeMarshal(Object source) {
                         beforeCalled.set(true);
                     }
+                    @Override
                     public void afterMarshal(Object source) {
                         afterCalled.set(true);
                     }