Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward Loss Threshold #1466

Open
fujiapple852 opened this issue Jan 2, 2025 · 0 comments
Open

Forward Loss Threshold #1466

fujiapple852 opened this issue Jan 2, 2025 · 0 comments
Labels
column enhancement New feature or request tui
Milestone

Comments

@fujiapple852
Copy link
Owner

Currently, forward loss for lost probe P is detected by examining if all subsequent probes are also lost, provided there is at least 1 subsequent problem.

This can lead to false positive for the 2nd last probe if the final probe appears "lost" but is not (i.e. is rate limited). The probability of this happening is high as it only takes 1 probe (the final probe, to the target) to be "lost" for forward loss to be declared. For the 3rd last probe it needs both the 2nd last and the last probe to be lost before it is considered forward loss.

For example, if hop 3 has a 10% chance of showing "fake" loss (i.e. is rate limited) then the probability of hop 2 incorrectly show forward loss 10% of the time:

TTL State Fake Loss %
1 Complete 0%
2 Lost 0%
3 Lost 10%

Here, if hops 3 and 4 both have a 10% chance of showing "fake" loss then the probability of hop 2 incorrectly showing forward loss is reduced to 1%:

TTL State Fake Loss %
1 Complete 0%
2 Lost 0%
3 Lost 10%
4 Lost 10%

Therefore, it may be sensible to set a minimum threshold for the number of subsequent hops that must show loss in a given round before it is deemed forward loss. Currently this minimum is implicitly fixed at 1, whereas it could be made configurable and given a larger default value of at least 2.

@fujiapple852 fujiapple852 added enhancement New feature or request tui column and removed tui labels Jan 14, 2025
@fujiapple852 fujiapple852 added this to the 0.13.0 milestone Jan 14, 2025
@fujiapple852 fujiapple852 added tui and removed triage labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
column enhancement New feature or request tui
Projects
None yet
Development

No branches or pull requests

1 participant