UploadBlob: store blob on best volume, not 1st volume (might not be online)

Author: joonas-fi

pkg/stoserver/restapi.go

@@ -1363,9 +1363,9 @@ func (h *handlers) UploadBlob(rctx *httpauth.RequestContext, w http.ResponseWrit
 			return err
 		}
 
-		volumeId = replicationPolicy.DesiredVolumes[0]
-
-		return nil
+		// save the blob first on the best volume (the one which is mounted and various other heuristics)
+		volumeId, err = h.conf.DiskAccess.BestVolumeId(replicationPolicy.DesiredVolumes)
+		return err
 	}); err != nil {
 		http.Error(w, err.Error(), http.StatusInternalServerError)
 		return

pkg/stoserver/stoservertypes/commands.json

@@ -593,7 +593,7 @@
 		"title": "Change desired volumes",
 		"fields": [
 			{ "key": "Id", "hideIfDefaultValue": true },
-			{ "key": "Volume1", "type": "custom/integer", "optional": true, "title": "First volume", "placeholder": "Fry", "help": "First volume is special - it's where the synchronous part of the replica is placed first (before the asynchronous replication kicks off)" },
+			{ "key": "Volume1", "type": "custom/integer", "optional": true, "title": "First volume", "placeholder": "Fry" },
 			{ "key": "Volume2", "type": "custom/integer", "optional": true, "title": "Second volume", "placeholder": "Leela" },
 			{ "key": "Volume3", "type": "custom/integer", "optional": true, "title": "Third volume" },
 			{ "key": "Volume4", "type": "custom/integer", "optional": true, "title": "Fourth volume" }