Skip to content

Create builder methods for VA spec objects #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahwagner opened this issue Mar 30, 2025 · 2 comments
Open

Create builder methods for VA spec objects #23

ahwagner opened this issue Mar 30, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ahwagner
Copy link
Member

Feature description

Write functions to generate VA-Spec objects associated with common community frameworks.

Use case

Implementers want an easy way to spin out evidence from common community frameworks to build VA Spec objects–simplifying what they need to learn and get started for common cases.

Proposed solution

Create a new extras.builders package with specific modules containing evidence codes, classifications, and evidence items from common frameworks (such as those specified in our models) populating fields in the way we would expect. These modules would use our existing pydantic models for these frameworks to ensure consistency.

Alternatives considered

No response

Implementation details

No response

Potential Impact

No response

Additional context

No response

Contribution

Yes, I can create a PR for this feature.

@ahwagner ahwagner added the enhancement New feature or request label Mar 30, 2025
@ahwagner ahwagner changed the title Create builder methods for oncogenicity statements Create builder methods for VA spec objects Mar 30, 2025
@ahwagner ahwagner self-assigned this Mar 31, 2025
@korikuzma
Copy link
Collaborator

@ahwagner in this PR, can you also update the Features section in the README?

I’m not sure if you’ll have time, but it would be really nice to also have a Jupyter Notebook with this work for #8 .

@korikuzma
Copy link
Collaborator

In VRS-Python, we’re wanting to rename the extras dependency. We should do the same here and probably just use builders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants