-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init migrate PlatyPS to Microsoft.PowerShell.PlatyPS #501
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
===================================
- Coverage 81% 81% -1%
===================================
Files 44 44
Lines 2338 2335 -3
===================================
- Hits 1913 1908 -5
- Misses 425 427 +2
|
@Gijsreyn are you still working on this? I waiting for the tests to pass. |
I thought the changelog only needed to be updated so all tests would pass, but I cannot seem why there are suddenly so many failures. I'll close it down to not break stuff @johlju. |
It looks like the errors were not the result of this PR but a change in DscResource.Test. You can reopen this if you like and I will fix the issue in a separate PR. |
Done! I was in shock in the failing tests... Let me know on the fix and then we can try again :) |
There are seemingly a bug in ModuleBuilder that prevents the integration tests in this repo from working fully on PS5.1, see PoshCode/ModuleBuilder#135. That needs to be fixed first before I can merge a fix to solve the issue with DscResource.Test in PR #514. 🙂 |
Pull Request
Pull Request (PR) description
Initialize migrating from PlatyPS to Microsoft.PowerShell.PlatyPS. Relates to #497
Deprecated
Task list
build.ps1 -ResolveDependency
).This change is