Skip to content

Commit ee469fb

Browse files
committed
fix a image loading issue when src attrubute is empty
1 parent 3f167ed commit ee469fb

File tree

5 files changed

+5
-17
lines changed

5 files changed

+5
-17
lines changed

dist/min/tiny-slider.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/sourcemaps/tiny-slider.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/tiny-slider.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -1191,14 +1191,11 @@ var tns = function(options) {
11911191
forEach(imgs, function(img) {
11921192
var src = img.src;
11931193

1194-
if (src.indexOf('data:image') < 0) {
1194+
if (src && src.indexOf('data:image') < 0) {
11951195
addEvents(img, imgEvents);
11961196
img.src = '';
11971197
img.src = src;
11981198
addClass(img, 'loading');
1199-
1200-
// check image cache
1201-
if (img.complete) { img.naturalWidth !== 0 ? imgLoaded(img) : imgFailed(img); }
12021199
} else if (!lazyload) {
12031200
imgLoaded(img);
12041201
}
@@ -2242,7 +2239,6 @@ var tns = function(options) {
22422239
}
22432240

22442241
function imgFailed (img) {
2245-
console.log(img, img.src);
22462242
addClass(img, 'failed');
22472243
imgCompleted(img);
22482244
}

src/tiny-slider.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -759,14 +759,11 @@ export var tns = function(options) {
759759
forEach(imgs, function(img) {
760760
var src = img.src;
761761

762-
if (src.indexOf('data:image') < 0) {
762+
if (src && src.indexOf('data:image') < 0) {
763763
addEvents(img, imgEvents);
764764
img.src = '';
765765
img.src = src;
766766
addClass(img, 'loading');
767-
768-
// check image cache
769-
if (img.complete) { img.naturalWidth !== 0 ? imgLoaded(img) : imgFailed(img); }
770767
} else if (!lazyload) {
771768
imgLoaded(img);
772769
}
@@ -1810,7 +1807,6 @@ export var tns = function(options) {
18101807
}
18111808

18121809
function imgFailed (img) {
1813-
console.log(img, img.src);
18141810
addClass(img, 'failed');
18151811
imgCompleted(img);
18161812
}

src/tiny-slider.module.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -759,14 +759,11 @@ export var tns = function(options) {
759759
forEach(imgs, function(img) {
760760
var src = img.src;
761761

762-
if (src.indexOf('data:image') < 0) {
762+
if (src && src.indexOf('data:image') < 0) {
763763
addEvents(img, imgEvents);
764764
img.src = '';
765765
img.src = src;
766766
addClass(img, 'loading');
767-
768-
// check image cache
769-
if (img.complete) { img.naturalWidth !== 0 ? imgLoaded(img) : imgFailed(img); }
770767
} else if (!lazyload) {
771768
imgLoaded(img);
772769
}
@@ -1810,7 +1807,6 @@ export var tns = function(options) {
18101807
}
18111808

18121809
function imgFailed (img) {
1813-
console.log(img, img.src);
18141810
addClass(img, 'failed');
18151811
imgCompleted(img);
18161812
}

0 commit comments

Comments
 (0)