Skip to content

Commit f753bf4

Browse files
committed
Cleanup unused test skipping
1 parent 2bac53b commit f753bf4

File tree

3 files changed

+0
-32
lines changed

3 files changed

+0
-32
lines changed

tests/ParsingRulesetTrait.php

-6
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,6 @@ public static function parseRulesetDataProvider(): array
2222
#[DataProvider('parseRulesetDataProvider')]
2323
public function testParsing(Rule $record): void
2424
{
25-
if (array_key_exists($record->name, $this->skipParsingRules)) {
26-
$this->markTestSkipped(
27-
'Skipped "' . $record->name . '": ' . $this->skipParsingRules[$record->name]
28-
);
29-
}
30-
3125
try {
3226
$raw = implode(', ', $record->raw);
3327
$parsedValue = Parser::{'parse' . ucfirst($record->header_type)}($raw);

tests/RulesetTestBase.php

-20
Original file line numberDiff line numberDiff line change
@@ -6,26 +6,6 @@
66

77
abstract class RulesetTestBase extends TestCase
88
{
9-
/**
10-
* An array of rules which should skip the parsing test.
11-
*
12-
* The element key should be the name of the rule, and the value should be
13-
* the message to provide for skipping the rule.
14-
*
15-
* @var array<string, string>
16-
*/
17-
protected array $skipParsingRules = [];
18-
19-
/**
20-
* An array of rules which should skip the serializing test.
21-
*
22-
* The element key should be the name of the rule, and the value should be
23-
* the message to provide for skipping the rule.
24-
*
25-
* @var array<string, string>
26-
*/
27-
protected array $skipSerializingRules = [];
28-
299
/**
3010
* @return array<string, array{Rule}>
3111
*/

tests/SerializingRulesetTrait.php

-6
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,6 @@ public static function serializeRulesetDataProvider(): array
2222
#[DataProvider('serializeRulesetDataProvider')]
2323
public function testSerializing(Rule $record): void
2424
{
25-
if (array_key_exists($record->name, $this->skipSerializingRules)) {
26-
$this->markTestSkipped(
27-
'Skipped "' . $record->name . '": ' . $this->skipSerializingRules[$record->name]
28-
);
29-
}
30-
3125
try {
3226
$serializedValue = Serializer::{'serialize' . ucfirst($record->header_type)}($record->expected);
3327

0 commit comments

Comments
 (0)