misc ui tweaks

Author: garethgeorge

webui/src/api.ts

@@ -26,7 +26,7 @@ const fetch = (
 
 const transport = createConnectTransport({
   baseUrl: "./",
-  useBinaryFormat: false,
+  useBinaryFormat: true,
   fetch: fetch as typeof globalThis.fetch,
 });
 

webui/src/views/AddRepoModal.tsx

@@ -14,6 +14,7 @@ import {
   Collapse,
   Checkbox,
   Select,
+  Space,
 } from "antd";
 import React, { useEffect, useState } from "react";
 import { useShowModal } from "../components/ModalManager";
@@ -38,6 +39,7 @@ import { useConfig } from "../components/ConfigProvider";
 import Cron from "react-js-cron";
 import { ScheduleFormItem } from "../components/ScheduleFormItem";
 import { proto3 } from "@bufbuild/protobuf";
+import { isWindows } from "../state/buildcfg";
 
 export const AddRepoModal = ({ template }: { template: Repo | null }) => {
   const [confirmLoading, setConfirmLoading] = useState(false);
@@ -495,55 +497,111 @@ export const AddRepoModal = ({ template }: { template: Repo | null }) => {
           </Form.Item>
 
           {/* Repo.commandPrefix */}
-          <Form.Item
-            label={
-              <Tooltip
-                title={
-                  <span>
-                    Modifiers for the backup operation e.g. set the CPU or IO
-                    priority. Currently only available on unix systems.
-                  </span>
-                }
-              >
-                Command Modifiers
-              </Tooltip>
-            }
-          >
-            <Row>
-              <Col span={12}>
-                <Form.Item name={["commandPrefix", "ioNice"]} required={false}>
-                  <Select
-                    allowClear
-                    style={{ width: "100%" }}
-                    placeholder="Select an IO priority"
-                    options={proto3
-                      .getEnumType(CommandPrefix_IONiceLevel)
-                      .values.map((v) => ({ label: v.name, value: v.name }))}
-                  />
-                </Form.Item>
-              </Col>
-
-              <Col span={12}>
-                <Form.Item name={["commandPrefix", "cpuNice"]} required={false}>
-                  <Select
-                    allowClear
-                    style={{ width: "100%" }}
-                    placeholder="Select a CPU priority"
-                    options={proto3
-                      .getEnumType(CommandPrefix_CPUNiceLevel)
-                      .values.map((v) => ({ label: v.name, value: v.name }))}
-                  />
-                </Form.Item>
-              </Col>
-            </Row>
-          </Form.Item>
+          {!isWindows && (
+            <Form.Item
+              label={
+                <Tooltip
+                  title={
+                    <span>
+                      Modifiers for the backup operation e.g. set the CPU or IO
+                      priority.
+                    </span>
+                  }
+                >
+                  Command Modifiers
+                </Tooltip>
+              }
+              colon={false}
+            >
+              <Row>
+                <Col span={12} style={{ paddingLeft: "5px" }}>
+                  <Tooltip
+                    title={
+                      <>
+                        Available IO priority modes
+                        <ul>
+                          <li>
+                            IO_BEST_EFFORT_LOW - runs at lower than default disk
+                            priority (will prioritize other processes)
+                          </li>
+                          <li>
+                            IO_BEST_EFFORT_HIGH - runs at higher than default
+                            disk priority (top of disk IO queue)
+                          </li>
+                          <li>
+                            IO_IDLE - only runs when disk bandwidth is idle
+                            (e.g. no other operations are queued)
+                          </li>
+                        </ul>
+                      </>
+                    }
+                  >
+                    IO Priority:
+                    <br />
+                    <Form.Item
+                      name={["commandPrefix", "ioNice"]}
+                      required={false}
+                    >
+                      <Select
+                        allowClear
+                        style={{ width: "100%" }}
+                        placeholder="Select an IO priority"
+                        options={proto3
+                          .getEnumType(CommandPrefix_IONiceLevel)
+                          .values.map((v) => ({
+                            label: v.name,
+                            value: v.name,
+                          }))}
+                      />
+                    </Form.Item>
+                  </Tooltip>
+                </Col>
+                <Col span={12} style={{ paddingLeft: "5px" }}>
+                  <Tooltip
+                    title={
+                      <>
+                        Available CPU priority modes:
+                        <ul>
+                          <li>CPU_DEFAULT - no change in priority</li>
+                          <li>
+                            CPU_HIGH - higher than default priority (backrest
+                            must be running as root)
+                          </li>
+                          <li>CPU_LOW - lower than default priority</li>
+                        </ul>
+                      </>
+                    }
+                  >
+                    CPU Priority:
+                    <br />
+                    <Form.Item
+                      name={["commandPrefix", "cpuNice"]}
+                      required={false}
+                    >
+                      <Select
+                        allowClear
+                        style={{ width: "100%" }}
+                        placeholder="Select a CPU priority"
+                        options={proto3
+                          .getEnumType(CommandPrefix_CPUNiceLevel)
+                          .values.map((v) => ({
+                            label: v.name,
+                            value: v.name,
+                          }))}
+                      />
+                    </Form.Item>
+                  </Tooltip>
+                </Col>
+              </Row>
+            </Form.Item>
+          )}
 
           <Form.Item
             label={
               <Tooltip
                 title={
                   "Auto-unlock will remove lockfiles at the start of forget and prune operations. " +
-                  "This is potentially unsafe if the repo is shared by multiple client devices. Opt-in (and disabled) by default."
+                  "This is potentially unsafe if the repo is shared by multiple client devices. Disabled by default."
                 }
               >
                 Auto Unlock