add test coverage

Author: garethgeorge

internal/orchestrator/repo/repo_test.go

@@ -20,39 +20,65 @@ var configForTest = &v1.Config{
 func TestBackup(t *testing.T) {
 	t.Parallel()
 
-	repo := t.TempDir()
 	testData := test.CreateTestData(t)
 
-	// create a new repo with cache disabled for testing
-	r := &v1.Repo{
-		Id:       "test",
-		Uri:      repo,
-		Password: "test",
-		Flags:    []string{"--no-cache"},
-	}
-
-	plan := &v1.Plan{
-		Id:    "test",
-		Repo:  "test",
-		Paths: []string{testData},
+	tcs := []struct {
+		name string
+		repo *v1.Repo
+		plan *v1.Plan
+	}{
+		{
+			name: "backup",
+			repo: &v1.Repo{
+				Id:       "test",
+				Uri:      t.TempDir(),
+				Password: "test",
+			},
+			plan: &v1.Plan{
+				Id:    "test",
+				Repo:  "test",
+				Paths: []string{testData},
+			},
+		},
+		{
+			name: "backup with ionice",
+			repo: &v1.Repo{
+				Id:       "test",
+				Uri:      t.TempDir(),
+				Password: "test",
+				CommandPrefix: &v1.CommandPrefix{
+					IoNice:  v1.CommandPrefix_IO_BEST_EFFORT_LOW,
+					CpuNice: v1.CommandPrefix_CPU_HIGH,
+				},
+			},
+			plan: &v1.Plan{
+				Id:    "test",
+				Repo:  "test",
+				Paths: []string{testData},
+			},
+		},
 	}
 
-	orchestrator, err := NewRepoOrchestrator(configForTest, r, helpers.ResticBinary(t))
-	if err != nil {
-		t.Fatalf("failed to create repo orchestrator: %v", err)
-	}
+	for _, tc := range tcs {
+		t.Run(tc.name, func(t *testing.T) {
+			orchestrator, err := NewRepoOrchestrator(configForTest, tc.repo, helpers.ResticBinary(t))
+			if err != nil {
+				t.Fatalf("failed to create repo orchestrator: %v", err)
+			}
 
-	summary, err := orchestrator.Backup(context.Background(), plan, nil)
-	if err != nil {
-		t.Fatalf("backup error: %v", err)
-	}
+			summary, err := orchestrator.Backup(context.Background(), tc.plan, nil)
+			if err != nil {
+				t.Fatalf("backup error: %v", err)
+			}
 
-	if summary.SnapshotId == "" {
-		t.Fatal("expected snapshot id")
-	}
+			if summary.SnapshotId == "" {
+				t.Fatal("expected snapshot id")
+			}
 
-	if summary.FilesNew != 100 {
-		t.Fatalf("expected 100 new files, got %d", summary.FilesNew)
+			if summary.FilesNew != 100 {
+				t.Fatalf("expected 100 new files, got %d", summary.FilesNew)
+			}
+		})
 	}
 }
 

webui/src/views/AddRepoModal.tsx

@@ -13,10 +13,16 @@ import {
   FormInstance,
   Collapse,
   Checkbox,
+  Select,
 } from "antd";
 import React, { useEffect, useState } from "react";
 import { useShowModal } from "../components/ModalManager";
-import { Hook, Repo } from "../../gen/ts/v1/config_pb";
+import {
+  CommandPrefix_CPUNiceLevel,
+  CommandPrefix_IONiceLevel,
+  Hook,
+  Repo,
+} from "../../gen/ts/v1/config_pb";
 import { URIAutocomplete } from "../components/URIAutocomplete";
 import { MinusCircleOutlined, PlusOutlined } from "@ant-design/icons";
 import { formatErrorAlert, useAlertApi } from "../components/Alerts";
@@ -31,6 +37,7 @@ import { ConfirmButton } from "../components/SpinButton";
 import { useConfig } from "../components/ConfigProvider";
 import Cron from "react-js-cron";
 import { ScheduleFormItem } from "../components/ScheduleFormItem";
+import { proto3 } from "@bufbuild/protobuf";
 
 export const AddRepoModal = ({ template }: { template: Repo | null }) => {
   const [confirmLoading, setConfirmLoading] = useState(false);
@@ -97,14 +104,15 @@ export const AddRepoModal = ({ template }: { template: Repo | null }) => {
       });
 
       if (template !== null) {
+        const configCopy = config.clone();
         // We are in the edit repo flow, update the repo in the config
-        const idx = config.repos!.findIndex((r) => r.id === template!.id);
+        const idx = configCopy.repos!.findIndex((r) => r.id === template!.id);
         if (idx === -1) {
           alertsApi.error("Can't update repo, not found");
           return;
         }
-        config.repos![idx] = repo;
-        setConfig(await backrestService.setConfig(config));
+        configCopy.repos![idx] = repo;
+        setConfig(await backrestService.setConfig(configCopy));
         showModal(null);
         alertsApi.success("Updated repo " + repo.uri);
 
@@ -486,6 +494,50 @@ export const AddRepoModal = ({ template }: { template: Repo | null }) => {
             <ScheduleFormItem name={["checkPolicy", "schedule"]} />
           </Form.Item>
 
+          {/* Repo.commandPrefix */}
+          <Form.Item
+            label={
+              <Tooltip
+                title={
+                  <span>
+                    Modifiers for the backup operation e.g. set the CPU or IO
+                    priority. Currently only available on unix systems.
+                  </span>
+                }
+              >
+                Command Modifiers
+              </Tooltip>
+            }
+          >
+            <Row>
+              <Col span={12}>
+                <Form.Item name={["commandPrefix", "ioNice"]} required={false}>
+                  <Select
+                    allowClear
+                    style={{ width: "100%" }}
+                    placeholder="Select an IO priority"
+                    options={proto3
+                      .getEnumType(CommandPrefix_IONiceLevel)
+                      .values.map((v) => ({ label: v.name, value: v.name }))}
+                  />
+                </Form.Item>
+              </Col>
+
+              <Col span={12}>
+                <Form.Item name={["commandPrefix", "cpuNice"]} required={false}>
+                  <Select
+                    allowClear
+                    style={{ width: "100%" }}
+                    placeholder="Select a CPU priority"
+                    options={proto3
+                      .getEnumType(CommandPrefix_CPUNiceLevel)
+                      .values.map((v) => ({ label: v.name, value: v.name }))}
+                  />
+                </Form.Item>
+              </Col>
+            </Row>
+          </Form.Item>
+
           <Form.Item
             label={
               <Tooltip